From: David Miller <davem@davemloft.net>
To: jian.w.wen@oracle.com
Cc: netdev@vger.kernel.org, john.r.fastabend@intel.com
Subject: Re: [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue_get
Date: Mon, 10 Jun 2019 09:06:02 -0700 (PDT) [thread overview]
Message-ID: <20190610.090602.2001139990603847705.davem@davemloft.net> (raw)
In-Reply-To: <20190610.090526.1763320783297544794.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 10 Jun 2019 09:05:26 -0700 (PDT)
> From: Jacob Wen <jian.w.wen@oracle.com>
> Date: Mon, 10 Jun 2019 14:38:21 +0800
>
>> It may return NULL thus we can't ignore it.
>
> Please repost with a proper signoff.
Also, you are breaking the reverse christmas tree ordering of the local
variables with your change. Please do not do that.
next prev parent reply other threads:[~2019-06-10 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 6:38 [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue_get Jacob Wen
2019-06-10 16:05 ` David Miller
2019-06-10 16:06 ` David Miller [this message]
2019-06-10 18:19 ` Cong Wang
2019-06-11 0:27 ` Jacob Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610.090602.2001139990603847705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jian.w.wen@oracle.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox