From: Jeremy Kerr <jk@codeconstruct.com.au>
To: admiyo@os.amperecomputing.com,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Thu, 06 Feb 2025 15:04:02 +0800 [thread overview]
Message-ID: <99629576779509c98782464df15fa77e658089e8.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250205183244.340197-2-admiyo@os.amperecomputing.com>
Hi Adam,
One minor note below if you end up re-rolling for other reasons, but
regardless of that:
Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>
> + /* ndev needs to be freed before the iomemory (mapped above) gets
> + * unmapped, devm resources get freed in reverse to the order they
> + * are added.
> + */
> + rc = mctp_register_netdev(ndev, &mctp_netdev_ops, MCTP_PHYS_BINDING_PCC);
> + if (rc)
> + goto cleanup_netdev;
> + return devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
You seem to have a trigger-happy spacebar; there is another double-space
creeping in here, after the 'return'.
Cheers,
Jeremy
next prev parent reply other threads:[~2025-02-06 7:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 18:32 [PATCH v17 0/1] MCTP Over PCC Transport admiyo
2025-02-05 18:32 ` [PATCH v17 1/1] mctp pcc: Implement MCTP over " admiyo
2025-02-06 7:04 ` Jeremy Kerr [this message]
2025-02-06 18:28 ` Adam Young
2025-02-07 0:30 ` Jeremy Kerr
2025-02-20 17:31 ` Adam Young
2025-02-20 18:10 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99629576779509c98782464df15fa77e658089e8.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox