From: Joe Damato <jdamato@fastly.com>
To: Adam Young <admiyo@amperemail.onmicrosoft.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
admiyo@os.amperecomputing.com,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Thu, 20 Feb 2025 13:10:28 -0500 [thread overview]
Message-ID: <Z7dwFKs-ysnJ2Rs4@LQ3V64L9R2> (raw)
In-Reply-To: <8f5a1f2d-5ff2-43f8-8964-a992d5554db6@amperemail.onmicrosoft.com>
On Thu, Feb 20, 2025 at 12:31:21PM -0500, Adam Young wrote:
> On 2/6/25 19:30, Jeremy Kerr wrote:
>
> > Hi Adam,
> >
> > > Is that your only concern with this patch?
> > Yes, hence the ack. If there are other changes that you end up doing in
> > response to other reviews, then please address the spacing thing too,
> > but that certainly doesn't warrant a new revision on its own.
> >
> > > What else would need to happen in order for this to get ACKed at this
> > > point?
> > It already has an ack from me.
> >
> > As for actual merging: If the netdev maintainers have further reviews,
> > please address those. If not, I assume they would merge in this window.
>
> Should I resubmit this patch with a title that includes net-next in order
> for it to be picked up? I can see that there is stuff being pulled in and
> net-next for 6.14 is at RC2.
I am not a maintainer and I don't speak for them, but I've been
following this submission so my guess would be:
- Fix the spacing issue Jeremy pointed out
- Include Jeremy's ack in the updated patch
- Submit a v18 with net-next in the subject line, an indicate in
the cover letter the two changes you've made (spacing issue and
adding Jeremy's ack).
prev parent reply other threads:[~2025-02-20 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 18:32 [PATCH v17 0/1] MCTP Over PCC Transport admiyo
2025-02-05 18:32 ` [PATCH v17 1/1] mctp pcc: Implement MCTP over " admiyo
2025-02-06 7:04 ` Jeremy Kerr
2025-02-06 18:28 ` Adam Young
2025-02-07 0:30 ` Jeremy Kerr
2025-02-20 17:31 ` Adam Young
2025-02-20 18:10 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7dwFKs-ysnJ2Rs4@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@amperemail.onmicrosoft.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox