From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
dsa@cumulusnetworks.com, idosch@mellanox.com
Subject: Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE
Date: Tue, 22 May 2018 08:04:45 -0700 [thread overview]
Message-ID: <9e2a1bc7-e80a-1642-3b83-2341fddc6097@gmail.com> (raw)
In-Reply-To: <1527000668-25253-2-git-send-email-roopa@cumulusnetworks.com>
On 05/22/2018 07:51 AM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
>
...
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index 4d622112..cf5cfc5 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -649,6 +649,10 @@ const struct nla_policy rtm_ipv4_policy[RTA_MAX + 1] = {
> [RTA_ENCAP] = { .type = NLA_NESTED },
> [RTA_UID] = { .type = NLA_U32 },
> [RTA_MARK] = { .type = NLA_U32 },
> + [RTA_TABLE] = { .type = NLA_U32 },
> + [RTA_IP_PROTO] = { .type = NLA_U8 },
> + [RTA_SPORT] = { .type = NLA_U16 },
> + [RTA_DPORT] = { .type = NLA_U16 },
> };
Hi Roopa
RTA_TABLE addition looks like a bug fix for net tree ?
This should be sent as an independent patch IMO.
Thanks.
next prev parent reply other threads:[~2018-05-22 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 14:51 [PATCH net-next v4 0/3] fib rule selftest Roopa Prabhu
2018-05-22 14:51 ` [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE Roopa Prabhu
2018-05-22 15:04 ` Eric Dumazet [this message]
2018-05-22 15:45 ` Roopa Prabhu
2018-05-22 14:51 ` [PATCH net-next v4 2/3] ipv6: " Roopa Prabhu
2018-05-22 14:51 ` [PATCH net-next v4 3/3] selftests: net: initial fib rule tests Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e2a1bc7-e80a-1642-3b83-2341fddc6097@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox