From: "Arnd Bergmann" <arnd@arndb.de>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Arthur Crépin Leblond" <arthur@marmottus.net>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios
Date: Mon, 10 Aug 2026 09:53:08 +0200 [thread overview]
Message-ID: <9e8fb566-e372-4519-ac0b-b8ca6de275e3@app.fastmail.com> (raw)
In-Reply-To: <20260810-arrogant-anteater-of-economy-ef2078@quoll>
On Mon, Aug 10, 2026, at 09:43, Krzysztof Kozlowski wrote:
> On Thu, Aug 06, 2026 at 05:00:01PM +0200, Arthur Crépin Leblond wrote:
>>
>> + link-gpios:
>> + description:
>> + An optional GPIO line that can be wired to the LINKLED pin of the w5500
>> + as an interrupt to detect link status changes.
>
> The message is confusing. If you describe it from the host (system point
> of view), then interrupts are not GPIOs but "interrupts".
>
> But maybe this is OUT GPIO from the system to the device?
From the device point of view, it's an LED output, but from the
system side we should describe it as an IRQ_TYPE_EDGE_BOTH
"interrupts" property rather than a gpio line.
Arnd
next prev parent reply other threads:[~2026-08-10 7:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 14:59 [PATCH net-next v3 0/3] w5100: restore GPIO-based link detection Arthur Crépin Leblond
2026-08-06 15:00 ` [PATCH net-next v3 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Arthur Crépin Leblond
2026-08-10 7:40 ` Krzysztof Kozlowski
2026-08-06 15:00 ` [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios Arthur Crépin Leblond
2026-08-10 7:43 ` Krzysztof Kozlowski
2026-08-10 7:50 ` Arthur Crépin Leblond
2026-08-10 7:53 ` Arnd Bergmann [this message]
2026-08-10 7:59 ` Krzysztof Kozlowski
2026-08-10 8:12 ` Arthur Crépin Leblond
2026-08-10 8:21 ` Krzysztof Kozlowski
2026-08-10 8:25 ` Arnd Bergmann
2026-08-10 8:31 ` Krzysztof Kozlowski
2026-08-10 14:46 ` Arthur Crépin Leblond
2026-08-10 7:55 ` Krzysztof Kozlowski
2026-08-06 15:00 ` [PATCH net-next v3 3/3] w5100: detect carrier state using link status bit Arthur Crépin Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e8fb566-e372-4519-ac0b-b8ca6de275e3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew+netdev@lunn.ch \
--cc=arthur@marmottus.net \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox