Re: [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/08/2026 09:43, Krzysztof Kozlowski wrote:
> On Thu, Aug 06, 2026 at 05:00:01PM +0200, Arthur Crépin Leblond wrote:
>> Add the link-gpios property which describes an optional GPIO line that
>> can be wired to the LINKLED pin of the w5500 as an interrupt to detect
>> link status changes.
>>
>> Signed-off-by: Arthur Crépin Leblond <arthur@marmottus.net>
>> ---
>>  Documentation/devicetree/bindings/net/wiznet,w5100.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
>> index 641c9ddbde9e..cebf437ad3c4 100644
>> --- a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
>> +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
>> @@ -35,6 +35,12 @@ properties:
>>        however, board designs may need to limit this value.
>>      maximum: 80000000
>>  
>> +  link-gpios:
>> +    description:
>> +      An optional GPIO line that can be wired to the LINKLED pin of the w5500
>> +      as an interrupt to detect link status changes.
> 
> The message is confusing. If you describe it from the host (system point
> of view), then interrupts are not GPIOs but "interrupts".
> 
> But maybe this is OUT GPIO from the system to the device?
> 

So I read your driver and hardware datasheet. This is not an interrupt,
just output pin, so drop the "interrupt" wording here.

This output pin can be wired to LED or to GPIO on the host side, so
ideally this would be mutually exclusive, but representing this as GPIO
is fine for now. Description could be:
"Active low LINKLED output pin reporting status of the link"

Best regards,
Krzysztof