From: Jun Yang <juny24602@gmail.com>
To: xiyou.wangcong@gmail.com
Cc: juny24602@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sched: address a potential NULL pointer dereference in the GRED scheduler.
Date: Wed, 5 Mar 2025 23:57:44 +0800 [thread overview]
Message-ID: <DB9B87BD-C829-4A06-B692-77324096AF4F@gmail.com> (raw)
On Wed, Mar 5, 2025 at 4:05 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> I think the whole gred_offload() should be skipped when table->opt ==
> NULL, espeically the last call of ->ndo_setup_tc(). Something like:
Thank you for your review. I have updated the part with my name.
I don't quite understand why the code would send a TC_SETUP_QDISC_GRED command during destroy. I haven't found the function that handles this command, so this part of the code should not produce side effects. Adding a check on the outer layer would indeed be safer. I have already modified this part of the patch.
next reply other threads:[~2025-03-05 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 15:57 Jun Yang [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-27 16:04 [PATCH] sched: address a potential NULL pointer dereference in the GRED scheduler kwqcheii
2025-02-27 18:26 ` Cong Wang
2025-03-04 14:18 ` kwqcheii
2025-03-04 20:05 ` Cong Wang
2025-03-05 15:44 ` Jun Yang
2025-03-05 18:22 ` Cong Wang
2025-03-07 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9B87BD-C829-4A06-B692-77324096AF4F@gmail.com \
--to=juny24602@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox