Netdev List
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: kwqcheii <juny24602@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sched: address a potential NULL pointer dereference in the GRED scheduler.
Date: Thu, 27 Feb 2025 10:26:59 -0800	[thread overview]
Message-ID: <Z8Cuc1sIjXMQaf3W@pop-os.localdomain> (raw)
In-Reply-To: <20250227160419.3065643-1-juny24602@gmail.com>

On Fri, Feb 28, 2025 at 12:04:19AM +0800, kwqcheii wrote:
> If kzalloc in gred_init returns a NULL pointer, the code follows the error handling path, invoking gred_destroy. This, in turn, calls gred_offload, where memset could receive a NULL pointer as input, potentially leading to a kernel crash.


Thanks for your patch.

Please add your Signed-off-by for your patch, which is a minimum
requirement here. You can check Linux kernel development process for
more details: https://docs.kernel.org/process/5.Posting.html#before-creating-patches

Also, ./scripts/checkpatch.pl could help you catch issues like this one,
it would save you and others a lot of time.

Lastly, if you saw a real crash, please include the kernel stack trace
in your patch description. There is a significant difference between a
real crash and a theoretical one.

Regards,
Cong

  reply	other threads:[~2025-02-27 18:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 16:04 [PATCH] sched: address a potential NULL pointer dereference in the GRED scheduler kwqcheii
2025-02-27 18:26 ` Cong Wang [this message]
2025-03-04 14:18 ` kwqcheii
2025-03-04 20:05   ` Cong Wang
2025-03-05 15:44     ` Jun Yang
2025-03-05 18:22       ` Cong Wang
2025-03-07  0:50       ` patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2025-03-05 15:57 Jun Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8Cuc1sIjXMQaf3W@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=juny24602@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox