From: "Brendan Jackman" <brendan.jackman@linux.dev>
To: "Brendan Jackman" <brendan.jackman@linux.dev>,
"Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
"Matthew Wilcox" <willy@infradead.org>
Cc: "Brendan Jackman" <jackmanb@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@kernel.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Johannes Weiner" <hannes@cmpxchg.org>, "Zi Yan" <ziy@nvidia.com>,
"Jan Kara" <jack@suse.cz>,
"Joshua Hahn" <joshua.hahnjy@gmail.com>,
"Byungchul Park" <byungchul@sk.com>,
"Gregory Price" <gourry@gourry.net>,
"Ying Huang" <ying.huang@linux.alibaba.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Hugh Dickins" <hughd@google.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chris Li" <chrisl@kernel.org>,
"Kairui Song" <kasong@tencent.com>,
"Kemeng Shi" <shikemeng@huaweicloud.com>,
"Nhat Pham" <nphamcs@gmail.com>,
"Baoquan He" <baoquan.he@linux.dev>,
"Barry Song" <baohua@kernel.org>,
"Youngjun Park" <youngjun.park@lge.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Thomas Gleixner" <tglx@kernel.org>,
"Chuck Lever" <cel@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>, "NeilBrown" <neil@brown.name>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
<iommu@lists.linux.dev>, <loongarch@lists.linux.dev>,
<linux-nfs@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm: move internal mempolicy APIs to new internal header
Date: Wed, 29 Jul 2026 11:50:32 +0000 [thread overview]
Message-ID: <DKB16T0X5I9D.2GCNPBS9VC95V@linux.dev> (raw)
In-Reply-To: <DK5767A146ZW.3LV5JXS7T4W1C@linux.dev>
On Wed Jul 22, 2026 at 3:15 PM UTC, Brendan Jackman wrote:
...
>>> We have a long history of people just moving stuff around in patches
>>> without knowing what the intent was if it should be moved.
>>
>> I guess this patch is not critical to the rest, if that's an issue.
>
> Well, for ALLOC_UNMAPPED we really do need an alloc_flags arg for this
> function, but we can always just go straight to what I described above.
> I.e. I can create the __ variant + wrapper from the start. It's just a
> question of whether we prefer:
>
> - "Yuck, there's a public wrapper here that we don't actually need", or
>
> - "We hid this mempolicy API and people might think we'd NACK a patch to
> un-hide it".0
>
> https://lore.kernel.org/all/20260703-alloc-trylock-v5-2-c87b714e19d3@google.com/
Uh yeah so in v3 I did not depend on this patch, I just went straight to
creating __folio_alloc_mpol_noprof() here:
https://lore.kernel.org/all/20260726-page_alloc-unmapped-v3-25-6f5729aa9832@google.com/
So yeah I'd say we can just drop this controversial patch and move
forwards with the other two?
next prev parent reply other threads:[~2026-07-29 11:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 14:30 [PATCH 0/3] mm: yet more cleanups for page_alloc APIs Brendan Jackman
2026-07-16 14:30 ` [PATCH 1/3] mm: move internal mempolicy APIs to new internal header Brendan Jackman
2026-07-16 15:22 ` Vlastimil Babka (SUSE)
2026-07-16 16:04 ` Brendan Jackman
2026-07-16 16:48 ` Matthew Wilcox
2026-07-16 16:57 ` Brendan Jackman
2026-07-20 17:40 ` Gregory Price
2026-07-20 17:52 ` Matthew Wilcox
2026-07-20 18:29 ` Gregory Price
2026-07-20 18:34 ` Vlastimil Babka (SUSE)
2026-07-22 15:15 ` Brendan Jackman
2026-07-29 11:50 ` Brendan Jackman [this message]
2026-07-29 15:49 ` Vlastimil Babka (SUSE)
2026-07-20 18:06 ` Vlastimil Babka (SUSE)
2026-07-16 14:30 ` [PATCH 2/3] mm, treewide: replace __folio_alloc_node() with folio_alloc_node() Brendan Jackman
2026-07-16 17:00 ` Brendan Jackman
2026-07-20 17:42 ` Gregory Price
2026-07-16 14:30 ` [PATCH 3/3] mm: move __folio_alloc() to page_alloc.h Brendan Jackman
2026-07-20 17:44 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKB16T0X5I9D.2GCNPBS9VC95V@linux.dev \
--to=brendan.jackman@linux.dev \
--cc=Dai.Ngo@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baoquan.he@linux.dev \
--cc=byungchul@sk.com \
--cc=cel@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chrisl@kernel.org \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=edumazet@google.com \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=horms@kernel.org \
--cc=hughd@google.com \
--cc=iommu@lists.linux.dev \
--cc=jack@suse.cz \
--cc=jackmanb@google.com \
--cc=jlayton@kernel.org \
--cc=joro@8bytes.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kasong@tencent.com \
--cc=kernel@xen0n.name \
--cc=kuba@kernel.org \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=mhocko@suse.com \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=nphamcs@gmail.com \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=tglx@kernel.org \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=vbabka@kernel.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
--cc=youngjun.park@lge.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox