* [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper
@ 2017-12-13 9:22 Russell King
2017-12-13 16:46 ` Andrew Lunn
2017-12-13 21:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2017-12-13 9:22 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli; +Cc: Jon Nettleton, netdev
When in SGMII-to-Copper mode, the fiber page is used for the MAC facing
link, and does not require configuration of the fiber auto-negotiation
settings. Avoid trying.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/marvell.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 1e3996b41af5..710110ead6ad 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -678,6 +678,10 @@ static int m88e1510_config_aneg(struct phy_device *phydev)
if (err < 0)
goto error;
+ /* Do not touch the fiber page if we're in copper->sgmii mode */
+ if (phydev->interface == PHY_INTERFACE_MODE_SGMII)
+ return 0;
+
/* Then the fiber link */
err = marvell_set_page(phydev, MII_MARVELL_FIBER_PAGE);
if (err < 0)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper
2017-12-13 9:22 [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper Russell King
@ 2017-12-13 16:46 ` Andrew Lunn
2017-12-13 21:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-12-13 16:46 UTC (permalink / raw)
To: Russell King; +Cc: Florian Fainelli, Jon Nettleton, netdev
On Wed, Dec 13, 2017 at 09:22:03AM +0000, Russell King wrote:
> When in SGMII-to-Copper mode, the fiber page is used for the MAC facing
> link, and does not require configuration of the fiber auto-negotiation
> settings. Avoid trying.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper
2017-12-13 9:22 [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper Russell King
2017-12-13 16:46 ` Andrew Lunn
@ 2017-12-13 21:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-12-13 21:13 UTC (permalink / raw)
To: rmk+kernel; +Cc: andrew, f.fainelli, jon, netdev
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Wed, 13 Dec 2017 09:22:03 +0000
> When in SGMII-to-Copper mode, the fiber page is used for the MAC facing
> link, and does not require configuration of the fiber auto-negotiation
> settings. Avoid trying.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-13 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13 9:22 [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper Russell King
2017-12-13 16:46 ` Andrew Lunn
2017-12-13 21:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox