[PATCH net] phylink: ensure AN is enabled

[PATCH net] phylink: ensure AN is enabled

[Russell King]

Ensure that we mark AN as enabled at boot time, rather than leaving
it disabled.  This is noticable if your SFP module is fiber, and you
it supports faster speeds than 1G with 2.5G support in place.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/phy/phylink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index e30339fca5cf..db5d5726ced9 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -567,6 +567,7 @@ struct phylink *phylink_create(struct net_device *ndev,
 	pl->link_config.pause = MLO_PAUSE_AN;
 	pl->link_config.speed = SPEED_UNKNOWN;
 	pl->link_config.duplex = DUPLEX_UNKNOWN;
+	pl->link_config.an_enabled = true;
 	pl->ops = ops;
 	__set_bit(PHYLINK_DISABLE_STOPPED, &pl->phylink_disable_state);
 
-- 
2.7.4

Re: [PATCH net] phylink: ensure AN is enabled

[Florian Fainelli]

Le 12/20/17 à 15:21, Russell King a écrit :
> Ensure that we mark AN as enabled at boot time, rather than leaving
> it disabled.  This is noticable if your SFP module is fiber, and you
> it supports faster speeds than 1G with 2.5G support in place.

(not worth a respin IMHO), s/you //?

> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
-- 
Florian

Re: [PATCH net] phylink: ensure AN is enabled

[David Miller]

From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Wed, 20 Dec 2017 23:21:34 +0000

> Ensure that we mark AN as enabled at boot time, rather than leaving
> it disabled.  This is noticable if your SFP module is fiber, and you
> it supports faster speeds than 1G with 2.5G support in place.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Also applied, and both of these phlink fixes are queued up for -stable
as well.