Netdev List
 help / color / mirror / Atom feed
From: Burton Windle <bwindle@fint.org>
To: netdev@oss.sgi.com
Subject: Trivial patch for printk in tcp_input.c
Date: Thu, 24 Jun 2004 13:02:12 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0406241255110.921@morpheus> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 610 bytes --]

Here is a trivial patch to add a newline at the end of a printk in
tcp_input.c.

patch is against 2.6.7.

Without this patch, the output of the printk in question looks like this:

tcp_parse_options: Illegal window scaling value 255 >14 received.tcp_parse_options: Illegal window scaling value 255 >14
received.tcp_parse_options: Illegal window scaling value 255 >14 received.tcp_parse_options: Illegal window scaling value 255 >14 received.

It might be nice if this printk told us where the packet came from, but
I'll save that for another patch.

--
Burton Windle                           bwindle@fint.org

[-- Attachment #2: fix newline in printk --]
[-- Type: TEXT/plain, Size: 465 bytes --]

--- linux/net/ipv4/tcp_input.c	2004-06-16 11:33:16.000000000 -0400
+++ linux-bw/net/ipv4/tcp_input.c	2004-06-24 12:53:06.000000000 -0400
@@ -2919,7 +2919,7 @@
 							if(tp->snd_wscale > 14) {
 								if(net_ratelimit())
 									printk("tcp_parse_options: Illegal window "
-									       "scaling value %d >14 received.",
+									       "scaling value %d >14 received.\n",
 									       tp->snd_wscale);
 								tp->snd_wscale = 14;
 							}

                 reply	other threads:[~2004-06-24 17:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0406241255110.921@morpheus \
    --to=bwindle@fint.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox