Netdev List
 help / color / mirror / Atom feed
* Trivial patch for printk in tcp_input.c
@ 2004-06-24 17:02 Burton Windle
  0 siblings, 0 replies; only message in thread
From: Burton Windle @ 2004-06-24 17:02 UTC (permalink / raw)
  To: netdev

[-- Attachment #1: Type: TEXT/PLAIN, Size: 610 bytes --]

Here is a trivial patch to add a newline at the end of a printk in
tcp_input.c.

patch is against 2.6.7.

Without this patch, the output of the printk in question looks like this:

tcp_parse_options: Illegal window scaling value 255 >14 received.tcp_parse_options: Illegal window scaling value 255 >14
received.tcp_parse_options: Illegal window scaling value 255 >14 received.tcp_parse_options: Illegal window scaling value 255 >14 received.

It might be nice if this printk told us where the packet came from, but
I'll save that for another patch.

--
Burton Windle                           bwindle@fint.org

[-- Attachment #2: fix newline in printk --]
[-- Type: TEXT/plain, Size: 465 bytes --]

--- linux/net/ipv4/tcp_input.c	2004-06-16 11:33:16.000000000 -0400
+++ linux-bw/net/ipv4/tcp_input.c	2004-06-24 12:53:06.000000000 -0400
@@ -2919,7 +2919,7 @@
 							if(tp->snd_wscale > 14) {
 								if(net_ratelimit())
 									printk("tcp_parse_options: Illegal window "
-									       "scaling value %d >14 received.",
+									       "scaling value %d >14 received.\n",
 									       tp->snd_wscale);
 								tp->snd_wscale = 14;
 							}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-06-24 17:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-24 17:02 Trivial patch for printk in tcp_input.c Burton Windle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox