From: James Morris <jmorris@namei.org>
To: Catherine Zhang <cxzhang@watson.ibm.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, chrisw@osdl.org,
herbert@gondor.apana.org.au, sds@tycho.nsa.gov,
tjaeger@cse.psu.edu, latten@austin.ibm.com, sergeh@us.ibm.com,
gcwilson@us.ibm.com, czhang.us@gmail.com
Subject: Re: [PATCH 1/1] LSM-IPsec SELinux Authorize
Date: Mon, 5 Jun 2006 18:32:09 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606051830140.7331@d.namei> (raw)
In-Reply-To: <20060605195607.GA28030@jiayuguan.watson.ibm.com>
On Mon, 5 Jun 2006, Catherine Zhang wrote:
Looks ok to me, except for one minor nit:
> + if (ctx) {
> + rc = avc_has_perm(tsec->sid, ctx->ctx_sid,
> + SECCLASS_ASSOCIATION,
> + ASSOCIATION__SETCONTEXT, NULL);
> + }
you don't need the braces here (similar again further in the patch).
- James
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2006-06-05 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 19:56 [PATCH 1/1] LSM-IPsec SELinux Authorize Catherine Zhang
2006-06-05 22:32 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606051830140.7331@d.namei \
--to=jmorris@namei.org \
--cc=chrisw@osdl.org \
--cc=cxzhang@watson.ibm.com \
--cc=czhang.us@gmail.com \
--cc=davem@davemloft.net \
--cc=gcwilson@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=latten@austin.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=sergeh@us.ibm.com \
--cc=tjaeger@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox