From: Patrick McHardy <kaber@trash.net>
To: Lucas Nussbaum <lucas.nussbaum@imag.fr>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify()
Date: Fri, 31 Aug 2007 11:35:38 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0708311135190.8423@x2> (raw)
In-Reply-To: <20070830072817.GA9617@xanadu.blop.info>
On Thu, 30 Aug 2007, Lucas Nussbaum wrote:
> When CONFIG_NET_CLS_ACT is enabled, tc_classify() is called twice in
> prio_classify(). This causes "interesting" behaviour: with the setup
> below, packets are duplicated, sent twice to ifb0, and then loop in and
> out of ifb0.
>
> The patch uses the previously calculated return value in the switch,
> which is probably what Patrick had in mind in commit
> bdba91ec70fb5ccbdeb1c7068319adc6ea9e1a7d -- maybe Patrick can
> double-check this?
Thanks for catching this, this is indeed what I had in mind.
prev parent reply other threads:[~2007-08-31 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 7:28 [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify() Lucas Nussbaum
2007-08-31 5:36 ` David Miller
2007-08-31 6:04 ` Patrick McHardy
2007-08-31 9:35 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708311135190.8423@x2 \
--to=kaber@trash.net \
--cc=lucas.nussbaum@imag.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox