Netdev List
 help / color / mirror / Atom feed
* [PATCH] drivers/net/wireless: correct check on CCS_START_NETWORK
@ 2009-11-08  8:23 Julia Lawall
  0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2009-11-08  8:23 UTC (permalink / raw)
  To: Corey Thomas, John W. Linville, linux-wireless, netdev,
	linux-kernel, kernel-janit

From: Julia Lawall <julia@diku.dk>

CCS_START_NETWORK is declared in drivers/net/wireless/rayctl.h with the
comment Values for cmd.  status is previously compared to
CCS_COMMAND_COMPLETE, which is declared in the same file with the comment
Values for buffer_status.  Finally, it is possible at this point that cmd
is CCS_START_NETWORK, because it is compared to that value in an enclosing
switch that has CCS_START_NETWORK as one of two case labels around this code.

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/net/wireless/ray_cs.c       |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 1c88c2e..5ee9d2a 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2074,7 +2074,7 @@ static irqreturn_t ray_interrupt(int irq, void *dev_id)
 				del_timer(&local->timer);
 				local->timer.expires = jiffies + HZ * 5;
 				local->timer.data = (long)local;
-				if (status == CCS_START_NETWORK) {
+				if (cmd == CCS_START_NETWORK) {
 					DEBUG(0,
 					      "ray_cs interrupt network \"%s\" start failed\n",
 					      local->sparm.b4.a_current_ess_id);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-11-08  8:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-08  8:23 [PATCH] drivers/net/wireless: correct check on CCS_START_NETWORK Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox