Netdev List
 help / color / mirror / Atom feed
From: Alexey Toptygin <alexeyt@freeshell.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: hzhong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] fix unlikely usage in tcp_transmit_skb()
Date: Fri, 28 Apr 2006 23:45:01 +0000 (UTC)	[thread overview]
Message-ID: <Pine.NEB.4.62.0604282324180.3253@norge.freeshell.org> (raw)
In-Reply-To: <20060428.152551.50641016.davem@davemloft.net>

On Fri, 28 Apr 2006, David S. Miller wrote:

> From: Hua Zhong <hzhong@gmail.com>
> Date: Wed, 26 Apr 2006 09:50:28 -0700 (PDT)
>
>> [I hope this time it's OK - I'm sending from pine/Linux]
>
> It adds an extra space in the diff lines which corrupts
> the patch.

You can work around this by enabling quell-flowed-text - then pine will 
never mangle patches. Currently (pine4.64), if you're disabling flowed 
text on a per-message basis with ^V before sending, patches containing 
trailing whitespace will get mangled. Pine labels the message as not 
flowed, but does the mangling anyway :-/

Tooting my own horn here, but I submitted a pine patch this week which 
fixes the issue. Hopefully, the next pine release will behave correctly. 
You'll still have to remember to hit ^V before sending mail containing 
patches, and you should always use ^R to include patch files, since 
newlines in the input are treated magically. Or, you can enable 
quell-flowed-text, and pretend the whole flowed text feature never 
happened. I'll shut up about pine now :-)

 			Alexey

      reply	other threads:[~2006-04-28 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26 16:50 [PATCH] fix unlikely usage in tcp_transmit_skb() Hua Zhong
2006-04-28 22:25 ` David S. Miller
2006-04-28 23:45   ` Alexey Toptygin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.NEB.4.62.0604282324180.3253@norge.freeshell.org \
    --to=alexeyt@freeshell.org \
    --cc=davem@davemloft.net \
    --cc=hzhong@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox