From: Jamal Hadi Salim <jhs@mojatatu.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
Victor Nogueira <victor@mojatatu.com>,
hybris <hybris@mojatatu.ai>,
sashiko-bot@kernel.org
Subject: [PATCH net 2/2] selftests: tc-testing: add duplicate action delete batch test
Date: Tue, 22 Sep 2026 12:33:59 -0400 [thread overview]
Message-ID: <QDISC-K1TH.v1.20260922072206@mojatatu.com.2> (raw)
tca_action_gd() takes one reference per nested TCA_ACT_TAB entry while
tcf_action_delete() consumes two per slot, so three duplicate
TCA_ACT_INDEX entries in one RTM_DELACTION free the action mid-walk and
the next slot dereferences it. Assert a duplicate batch is rejected and
the action survives.
Conditions to recreate the bug:
tc actions add action pass index 1
tc actions delete action gact index 1 action gact index 1 \
action gact index 1
Testing:
Case 8135 fails on the unfixed kernel (tdc_8135_unfixed.log) and passes
with the fix, alongside the batch-delete family (tdc_8135_fixed.log).
Tested-by: hybris <hybris@mojatatu.ai>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
.../tc-tests/actions/batch-delete.json | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json b/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
index ef7ca4a6775b..7620e927ae2c 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
@@ -111,5 +111,38 @@
255
]
]
+ },
+ {
+ "id": "8135",
+ "name": "Reject duplicate action in a delete batch",
+ "category": [
+ "actions",
+ "gact"
+ ],
+ "plugins": {
+ "requires": "nsPlugin"
+ },
+ "setup": [
+ [
+ "$TC actions flush action gact",
+ 0,
+ 1,
+ 255
+ ],
+ "$TC actions add action pass index 1"
+ ],
+ "cmdUnderTest": "$TC actions del action gact index 1 action gact index 1 action gact index 1",
+ "expExitCode": "255",
+ "verifyCmd": "$TC actions ls action gact",
+ "matchPattern": "total acts 1\\b.*index 1 ref 1 bind 0\\b",
+ "matchCount": "1",
+ "teardown": [
+ [
+ "$TC actions flush action gact",
+ 0,
+ 1,
+ 255
+ ]
+ ]
}
]
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Victor Nogueira <victor@mojatatu.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, hybris <hybris@mojatatu.ai>,
sashiko-bot@kernel.org
Subject: [PATCH net 2/2 repost] selftests: tc-testing: add duplicate action delete batch test
Date: Fri, 25 Sep 2026 04:22:38 -0400 [thread overview]
Message-ID: <QDISC-K1TH.v1.20260922072206@mojatatu.com.2> (raw)
Message-ID: <20260925082238.ApYMOyeo4f2cyHtNpBH4bmakwqO17BYdV-HiDQLVM3s@z> (raw)
In-Reply-To: <QDISC-K1TH.v1.20260922072206@mojatatu.com>
tca_action_gd() takes one reference per nested TCA_ACT_TAB entry while
tcf_action_delete() consumes two per slot, so three duplicate
TCA_ACT_INDEX entries in one RTM_DELACTION free the action mid-walk and
the next slot dereferences it. Assert a duplicate batch is rejected and
the action survives.
Conditions to recreate the bug:
tc actions add action pass index 1
tc actions delete action gact index 1 action gact index 1 \
action gact index 1
Testing:
Case 8135 fails on the unfixed kernel (tdc_8135_unfixed.log) and passes
with the fix, alongside the batch-delete family (tdc_8135_fixed.log).
Tested-by: hybris <hybris@mojatatu.ai>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
.../tc-tests/actions/batch-delete.json | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json b/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
index ef7ca4a6775b..7620e927ae2c 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
@@ -111,5 +111,38 @@
255
]
]
+ },
+ {
+ "id": "8135",
+ "name": "Reject duplicate action in a delete batch",
+ "category": [
+ "actions",
+ "gact"
+ ],
+ "plugins": {
+ "requires": "nsPlugin"
+ },
+ "setup": [
+ [
+ "$TC actions flush action gact",
+ 0,
+ 1,
+ 255
+ ],
+ "$TC actions add action pass index 1"
+ ],
+ "cmdUnderTest": "$TC actions del action gact index 1 action gact index 1 action gact index 1",
+ "expExitCode": "255",
+ "verifyCmd": "$TC actions ls action gact",
+ "matchPattern": "total acts 1\\b.*index 1 ref 1 bind 0\\b",
+ "matchCount": "1",
+ "teardown": [
+ [
+ "$TC actions flush action gact",
+ 0,
+ 1,
+ 255
+ ]
+ ]
}
]
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Victor Nogueira <victor@mojatatu.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, hybris <hybris@mojatatu.ai>,
sashiko-bot@kernel.org
Subject: [PATCH net 2/2 repost2] selftests: tc-testing: add duplicate action delete batch test
Date: Sat, 3 Oct 2026 05:54:54 -0400 [thread overview]
Message-ID: <QDISC-K1TH.v1.20260922072206@mojatatu.com.2> (raw)
Message-ID: <20261003095454.A4i__8DE05M3wQB_gihs9BDHXVQXu0XpMHEs0y-k3Ow@z> (raw)
In-Reply-To: <QDISC-K1TH.v1.20260922072206@mojatatu.com>
tca_action_gd() takes one reference per nested TCA_ACT_TAB entry while
tcf_action_delete() consumes two per slot, so three duplicate
TCA_ACT_INDEX entries in one RTM_DELACTION free the action mid-walk and
the next slot dereferences it. Assert a duplicate batch is rejected and
the action survives.
Conditions to recreate the bug:
tc actions add action pass index 1
tc actions delete action gact index 1 action gact index 1 \
action gact index 1
Testing:
Case 8135 fails on the unfixed kernel (tdc_8135_unfixed.log) and passes
with the fix, alongside the batch-delete family (tdc_8135_fixed.log).
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
.../tc-tests/actions/batch-delete.json | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json b/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
index ef7ca4a6775b..7620e927ae2c 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/batch-delete.json
@@ -111,5 +111,38 @@
255
]
]
+ },
+ {
+ "id": "8135",
+ "name": "Reject duplicate action in a delete batch",
+ "category": [
+ "actions",
+ "gact"
+ ],
+ "plugins": {
+ "requires": "nsPlugin"
+ },
+ "setup": [
+ [
+ "$TC actions flush action gact",
+ 0,
+ 1,
+ 255
+ ],
+ "$TC actions add action pass index 1"
+ ],
+ "cmdUnderTest": "$TC actions del action gact index 1 action gact index 1 action gact index 1",
+ "expExitCode": "255",
+ "verifyCmd": "$TC actions ls action gact",
+ "matchPattern": "total acts 1\\b.*index 1 ref 1 bind 0\\b",
+ "matchCount": "1",
+ "teardown": [
+ [
+ "$TC actions flush action gact",
+ 0,
+ 1,
+ 255
+ ]
+ ]
}
]
--
2.43.0
next prev reply other threads:[~2026-09-22 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 11:50 [PATCH net 1/2] net/sched: act_api: reject duplicate actions in a batch Jamal Hadi Salim
2026-09-22 16:33 ` Jamal Hadi Salim [this message]
2026-09-24 17:32 ` [PATCH net 2/2] selftests: tc-testing: add duplicate action delete batch test Jakub Kicinski
2026-09-24 20:09 ` Jamal Hadi Salim
2026-09-24 20:42 ` Jakub Kicinski
2026-09-25 8:15 ` Jamal Hadi Salim
2026-09-28 23:40 ` Jakub Kicinski
2026-09-25 8:22 ` [PATCH net 2/2 repost] " Jamal Hadi Salim
2026-10-03 9:54 ` [PATCH net 2/2 repost2] " Jamal Hadi Salim
2026-09-24 17:29 ` [PATCH net 1/2] net/sched: act_api: reject duplicate actions in a batch Jakub Kicinski
2026-09-25 8:22 ` [PATCH net 1/2 repost] " Jamal Hadi Salim
2026-10-03 9:54 ` [PATCH net 1/2 repost2] " Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=QDISC-K1TH.v1.20260922072206@mojatatu.com.2 \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hybris@mojatatu.ai \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=shuah@kernel.org \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox