From: nick black <dankamongmen@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jeffrey Ji <jeffreyji@google.com>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry
Date: Tue, 28 Feb 2023 07:59:30 -0500 [thread overview]
Message-ID: <Y/36sjlV6dWonLhC@schwarzgerat.orthanc> (raw)
In-Reply-To: <20230227104054.4a571060@kernel.org>
Jakub Kicinski left as an exercise for the reader:
> How about a banner before rx_otherhost_dropped? Maybe:
>
> /* end of old stats -- new stats via rtnetlink only */
sounds good to me; I'll also annotate the sysfs documentation to
emphasize that netlink is recommended, and that new stats will
not be reflected there. from the perspective of an outsider like
myself, it just looks like this stat was missed.
i'll have a new patch for you shortly. thank you for your review!
--
nick black -=- https://www.nick-black.com
to make an apple pie from scratch,
you need first invent a universe.
next prev parent reply other threads:[~2023-02-28 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 21:12 [PATCH] [net] add rx_otherhost_dropped sysfs entry nick black
2023-02-27 18:23 ` Jakub Kicinski
2023-02-27 18:29 ` nick black
2023-02-27 18:35 ` Eric Dumazet
2023-02-27 18:40 ` Jakub Kicinski
2023-02-28 12:59 ` nick black [this message]
2023-02-28 13:08 ` nick black
2023-02-28 20:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/36sjlV6dWonLhC@schwarzgerat.orthanc \
--to=dankamongmen@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jeffreyji@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox