Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry

[nick black <dankamongmen@gmail.com>]

Jakub Kicinski left as an exercise for the reader:
> "All the other stats are there" is not a strong enough reason
> to waste memory on all systems. You need to justify the change
> based on how important the counter is. I'd prefer to draw a
> line on adding the sysfs stats entries. We don't want to have 
> to invent a new stats struct just to avoid having sysfs entries
> for each stat.

In that case, I think a comment here is warranted explaining why
this stat, out of 24 total, isn't important enough to reproduce
in sysfs. I'm not sure what this comment would be:
rx_otherhost_dropped certainly seems as useful as, say
rx_compressed (only valid on e.g. CSLIP and PPP).

If this stat is left out of the sysfs interface, I'm likely to
just grab the rtnl_link_stats64 directly via netlink, and forgo
the sysfs interface entirely. If, in a modern switched world,
I'm receiving many packets destined for other hosts, that's at
least as interesting to me as several other classes of RX error.

-- 
nick black -=- https://www.nick-black.com
to make an apple pie from scratch,
you need first invent a universe.