* [PATCH -next] netfilter: nft_inner: fix return value check in nft_inner_parse_l2l3()
@ 2022-11-01 1:37 Peng Wu
2022-11-01 11:18 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Peng Wu @ 2022-11-01 1:37 UTC (permalink / raw)
To: pablo, kadlec, fw, davem, edumazet, kuba, pabeni
Cc: coreteam, netdev, liwei391, Peng Wu
In nft_inner_parse_l2l3(), the return value of skb_header_pointer() is
'veth' instead of 'eth' when case 'htons(ETH_P_8021Q)' and fix it.
Fixes: 3a07327d10a0 ("netfilter: nft_inner: support for inner tunnel header matching")
Signed-off-by: Peng Wu <wupeng58@huawei.com>
---
net/netfilter/nft_inner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_inner.c b/net/netfilter/nft_inner.c
index eae7caeff316..809f0d0787ec 100644
--- a/net/netfilter/nft_inner.c
+++ b/net/netfilter/nft_inner.c
@@ -72,7 +72,7 @@ static int nft_inner_parse_l2l3(const struct nft_inner *priv,
break;
case htons(ETH_P_8021Q):
veth = skb_header_pointer(pkt->skb, off, sizeof(_veth), &_veth);
- if (!eth)
+ if (!veth)
return -1;
outer_llproto = veth->h_vlan_encapsulated_proto;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] netfilter: nft_inner: fix return value check in nft_inner_parse_l2l3()
2022-11-01 1:37 [PATCH -next] netfilter: nft_inner: fix return value check in nft_inner_parse_l2l3() Peng Wu
@ 2022-11-01 11:18 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2022-11-01 11:18 UTC (permalink / raw)
To: Peng Wu
Cc: kadlec, fw, davem, edumazet, kuba, pabeni, coreteam, netdev,
liwei391
On Tue, Nov 01, 2022 at 01:37:28AM +0000, Peng Wu wrote:
> In nft_inner_parse_l2l3(), the return value of skb_header_pointer() is
> 'veth' instead of 'eth' when case 'htons(ETH_P_8021Q)' and fix it.
Applied to nf-next, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-01 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-01 1:37 [PATCH -next] netfilter: nft_inner: fix return value check in nft_inner_parse_l2l3() Peng Wu
2022-11-01 11:18 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox