* [PATCH net] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up()
@ 2022-11-07 9:34 Zhengchao Shao
2022-11-09 13:20 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Zhengchao Shao @ 2022-11-07 9:34 UTC (permalink / raw)
To: netdev, rajur, davem, edumazet, kuba, pabeni
Cc: jeffrey.t.kirsher, weiyongjun1, yuehaibing, shaozhengchao
When failed to bind qsets in cxgb_up() for opening device, napi isn't
disabled. When open cxgb3 device next time, it will reports a invalid
opcode issue. Fix it. Only be compiled, not be tested.
Fixes: f7917c009c28 ("chelsio: Move the Chelsio drivers")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
index a52e6b6e2876..9b84c8d8d309 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
@@ -1301,6 +1301,7 @@ static int cxgb_up(struct adapter *adap)
if (ret < 0) {
CH_ERR(adap, "failed to bind qsets, err %d\n", ret);
t3_intr_disable(adap);
+ quiesce_rx(adap);
free_irq_resources(adap);
err = ret;
goto out;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up()
2022-11-07 9:34 [PATCH net] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up() Zhengchao Shao
@ 2022-11-09 13:20 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-11-09 13:20 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, rajur, davem, edumazet, kuba, pabeni, jeffrey.t.kirsher,
weiyongjun1, yuehaibing
On Mon, Nov 07, 2022 at 05:34:23PM +0800, Zhengchao Shao wrote:
> When failed to bind qsets in cxgb_up() for opening device, napi isn't
> disabled. When open cxgb3 device next time, it will reports a invalid
> opcode issue. Fix it. Only be compiled, not be tested.
>
> Fixes: f7917c009c28 ("chelsio: Move the Chelsio drivers")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-09 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-07 9:34 [PATCH net] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up() Zhengchao Shao
2022-11-09 13:20 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox