From: Ido Schimmel <idosch@idosch.org>
To: Leonid Komaryanskiy <lkomaryanskiy@gmail.com>
Cc: netdev@vger.kernel.org, dmytro_firsov@epam.com, petrm@nvidia.com,
davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org
Subject: Re: ip_forward notification for driver
Date: Sun, 4 Dec 2022 11:05:18 +0200 [thread overview]
Message-ID: <Y4xizqncq1JTvNMu@shredder> (raw)
In-Reply-To: <CAHRDKfSoNdWWjv8X6-fBvaaaJ7wFekvKAYkfD01JBcqrMiLtUA@mail.gmail.com>
On Thu, Dec 01, 2022 at 05:21:10PM +0200, Leonid Komaryanskiy wrote:
> We checked netevents (NETEVENT_IPV4_MPATH_HASH_UPDATE and
> NETEVENT_IPV4_FWD_UPDATE_PRIORITY_UPDATE) but unfortunately, netevents
> notifier doesn't trigger at all in case of changing value in
> /proc/sys/net/ipv4/ip_forward. We see, that these events come in the
> case of modifying /proc/sys/net/ipv4/fib_multipath_hash_policy, but
> not for ip_forward. Shell we prepare an upstream patch with notifier
> for ip_forward modify netevent?
I believe this is the correct interface to use for this notification,
but if you are going to submit such a patch, then it needs to be
submitted together with a patch for a driver that listens to the event
an acts upon it. New APIs without an upstream user are not allowed.
Also, please make sure you add a test under
tools/testing/selftests/net/forwarding/.
P.S. Please avoid top-posting as explained here:
https://docs.kernel.org/process/2.Process.html#mailing-lists
prev parent reply other threads:[~2022-12-04 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 7:51 ip_forward notification for driver Leonid Komaryanskiy
2022-11-10 8:15 ` Ido Schimmel
2022-12-01 15:21 ` Leonid Komaryanskiy
2022-12-04 9:05 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4xizqncq1JTvNMu@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dmytro_firsov@epam.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=lkomaryanskiy@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox