[PATCH iproute2-next] libnetlink: Fix wrong netlink header placement

[PATCH iproute2-next] libnetlink: Fix wrong netlink header placement

[Ido Schimmel]

The netlink header must be first in the netlink message, so move it
there.

Fixes: fee4a56f0191 ("Update kernel headers")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 include/libnetlink.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/libnetlink.h b/include/libnetlink.h
index 4d9696efa253..c91a22314548 100644
--- a/include/libnetlink.h
+++ b/include/libnetlink.h
@@ -38,9 +38,9 @@ struct nlmsg_chain {
 };
 
 struct ipstats_req {
+	struct nlmsghdr nlh;
 	struct if_stats_msg ifsm;
 	char buf[128];
-	struct nlmsghdr nlh;
 };
 
 extern int rcvbuf;
-- 
2.37.3

Re: [PATCH iproute2-next] libnetlink: Fix wrong netlink header placement

[Jiri Pirko]

Thu, Dec 08, 2022 at 03:38:16PM CET, idosch@nvidia.com wrote:
>The netlink header must be first in the netlink message, so move it
>there.
>
>Fixes: fee4a56f0191 ("Update kernel headers")
>Signed-off-by: Ido Schimmel <idosch@nvidia.com>

Interesing.

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Re: [PATCH iproute2-next] libnetlink: Fix wrong netlink header placement

[David Ahern]

On 12/8/22 7:38 AM, Ido Schimmel wrote:
> The netlink header must be first in the netlink message, so move it
> there.
> 
> Fixes: fee4a56f0191 ("Update kernel headers")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
>  include/libnetlink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libnetlink.h b/include/libnetlink.h
> index 4d9696efa253..c91a22314548 100644
> --- a/include/libnetlink.h
> +++ b/include/libnetlink.h
> @@ -38,9 +38,9 @@ struct nlmsg_chain {
>  };
>  
>  struct ipstats_req {
> +	struct nlmsghdr nlh;
>  	struct if_stats_msg ifsm;
>  	char buf[128];
> -	struct nlmsghdr nlh;
>  };
>  
>  extern int rcvbuf;

thanks for noticing this. Must have been stale diff on the branch when I
was looking into the flex-array problem.

Re: [PATCH iproute2-next] libnetlink: Fix wrong netlink header placement

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Thu,  8 Dec 2022 16:38:16 +0200 you wrote:
> The netlink header must be first in the netlink message, so move it
> there.
> 
> Fixes: fee4a56f0191 ("Update kernel headers")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
>  include/libnetlink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [iproute2-next] libnetlink: Fix wrong netlink header placement
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=fa94a9792155

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html