* [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator
@ 2023-01-02 9:53 Daniil Tatianin
2023-01-02 15:39 ` Jiri Pirko
2023-01-03 9:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Daniil Tatianin @ 2023-01-02 9:53 UTC (permalink / raw)
To: netdev
Cc: Daniil Tatianin, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Otherwise we would dereference a NULL aggregator pointer when calling
__set_agg_ports_ready on the line below.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
---
Changes since v1:
- Added a fixes tag
---
drivers/net/bonding/bond_3ad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index acb6ff0be5ff..320e5461853f 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -1520,6 +1520,7 @@ static void ad_port_selection_logic(struct port *port, bool *update_slave_arr)
slave_err(bond->dev, port->slave->dev,
"Port %d did not find a suitable aggregator\n",
port->actor_port_number);
+ return;
}
}
/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator
2023-01-02 9:53 [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator Daniil Tatianin
@ 2023-01-02 15:39 ` Jiri Pirko
2023-01-03 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2023-01-02 15:39 UTC (permalink / raw)
To: Daniil Tatianin
Cc: netdev, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Mon, Jan 02, 2023 at 10:53:35AM CET, d-tatianin@yandex-team.ru wrote:
>Otherwise we would dereference a NULL aggregator pointer when calling
>__set_agg_ports_ready on the line below.
>
>Found by Linux Verification Center (linuxtesting.org) with the SVACE
>static analysis tool.
>
>Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator
2023-01-02 9:53 [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator Daniil Tatianin
2023-01-02 15:39 ` Jiri Pirko
@ 2023-01-03 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-03 9:20 UTC (permalink / raw)
To: Daniil Tatianin
Cc: netdev, linux-kernel, j.vosburgh, vfalico, andy, davem, edumazet,
kuba, pabeni
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 2 Jan 2023 12:53:35 +0300 you wrote:
> Otherwise we would dereference a NULL aggregator pointer when calling
> __set_agg_ports_ready on the line below.
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
>
> [...]
Here is the summary with links:
- [net,v2] drivers/net/bonding/bond_3ad: return when there's no aggregator
https://git.kernel.org/netdev/net/c/9c807965483f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-03 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-02 9:53 [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator Daniil Tatianin
2023-01-02 15:39 ` Jiri Pirko
2023-01-03 9:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox