From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next] devlink: remove a dubious assumption in fmsg dumping
Date: Tue, 24 Jan 2023 13:18:28 +0100 [thread overview]
Message-ID: <Y8/MlMWmkVBjQlfZ@nanopsycho> (raw)
In-Reply-To: <20230124035231.787381-1-kuba@kernel.org>
Tue, Jan 24, 2023 at 04:52:31AM CET, kuba@kernel.org wrote:
>Build bot detects that err may be returned uninitialized in
>devlink_fmsg_prepare_skb(). This is not really true because
>all fmsgs users should create at least one outer nest, and
>therefore fmsg can't be completely empty.
>
>That said the assumption is not trivial to confirm, so let's
>follow the bots advice, anyway.
>
>This code does not seem to have changed since its inception in
>commit 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API")
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-01-24 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 3:52 [PATCH net-next] devlink: remove a dubious assumption in fmsg dumping Jakub Kicinski
2023-01-24 12:18 ` Jiri Pirko [this message]
2023-01-25 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8/MlMWmkVBjQlfZ@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox