[PATCH net-next] devlink: remove a dubious assumption in fmsg dumping

[PATCH net-next] devlink: remove a dubious assumption in fmsg dumping

[Jakub Kicinski]

Build bot detects that err may be returned uninitialized in
devlink_fmsg_prepare_skb(). This is not really true because
all fmsgs users should create at least one outer nest, and
therefore fmsg can't be completely empty.

That said the assumption is not trivial to confirm, so let's
follow the bots advice, anyway.

This code does not seem to have changed since its inception in
commit 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API")

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/devlink/leftover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
index 8eab95cae917..74621287f4e5 100644
--- a/net/devlink/leftover.c
+++ b/net/devlink/leftover.c
@@ -7116,8 +7116,8 @@ devlink_fmsg_prepare_skb(struct devlink_fmsg *fmsg, struct sk_buff *skb,
 {
 	struct devlink_fmsg_item *item;
 	struct nlattr *fmsg_nlattr;
+	int err = 0;
 	int i = 0;
-	int err;
 
 	fmsg_nlattr = nla_nest_start_noflag(skb, DEVLINK_ATTR_FMSG);
 	if (!fmsg_nlattr)
-- 
2.39.1

Re: [PATCH net-next] devlink: remove a dubious assumption in fmsg dumping

[Jiri Pirko]

Tue, Jan 24, 2023 at 04:52:31AM CET, kuba@kernel.org wrote:
>Build bot detects that err may be returned uninitialized in
>devlink_fmsg_prepare_skb(). This is not really true because
>all fmsgs users should create at least one outer nest, and
>therefore fmsg can't be completely empty.
>
>That said the assumption is not trivial to confirm, so let's
>follow the bots advice, anyway.
>
>This code does not seem to have changed since its inception in
>commit 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API")
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Re: [PATCH net-next] devlink: remove a dubious assumption in fmsg dumping

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 23 Jan 2023 19:52:31 -0800 you wrote:
> Build bot detects that err may be returned uninitialized in
> devlink_fmsg_prepare_skb(). This is not really true because
> all fmsgs users should create at least one outer nest, and
> therefore fmsg can't be completely empty.
> 
> That said the assumption is not trivial to confirm, so let's
> follow the bots advice, anyway.
> 
> [...]

Here is the summary with links:
  - [net-next] devlink: remove a dubious assumption in fmsg dumping
    https://git.kernel.org/netdev/net-next/c/4373a023e038

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html