Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Wenzel, Marco" <Marco.Wenzel@a-eberle.de>
Cc: George McCollister <george.mccollister@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: HSR/PRP sequence counter issue with Cisco Redbox
Date: Wed, 17 Feb 2021 20:51:16 +0100	[thread overview]
Message-ID: <YC1ztKr/bpmc71Xh@lunn.ch> (raw)
In-Reply-To: <e20bb1bd30e9465ea36d26b274b8b2b6@EXCH-SVR2013.eberle.local>

> From 8836f1df35a884327da37885ff3ad8bfc5eb933c Mon Sep 17 00:00:00 2001
> From: Marco Wenzel <marco.wenzel@a-eberle.de>
> Date: Wed, 17 Feb 2021 13:53:31 +0100
> Subject: [PATCH] net: hsr: add support for EntryForgetTime
> 
> In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a
> node does not send any frame within this time, the sequence number check
> for can be ignored. This solves communication issues with Cisco IE 2000
> in Redbox mode.
> 
> Signed-off-by: Marco Wenzel <marco.wenzel@a-eberle.de>

It would be nice to have a Fixes: tag here to indicate which commit
introduced the problem. If it has been broken forever, reference the
commit which added HSR. 

> diff --git a/net/hsr/hsr_framereg.h b/net/hsr/hsr_framereg.h
> index 86b43f539f2c..7a120ce3e3db 100644
> --- a/net/hsr/hsr_framereg.h
> +++ b/net/hsr/hsr_framereg.h
> @@ -75,6 +75,7 @@ struct hsr_node {
>  	enum hsr_port_type	addr_B_port;
>  	unsigned long		time_in[HSR_PT_PORTS];
>  	bool			time_in_stale[HSR_PT_PORTS];
> +	unsigned long	  time_out[HSR_PT_PORTS];

It looks like the indentation is wrong here, and is using a mixture of
tabs and spaces.

     Andrew

      parent reply	other threads:[~2021-02-17 19:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 12:15 HSR/PRP sequence counter issue with Cisco Redbox Wenzel, Marco
2021-01-28 23:11 ` George McCollister
2021-02-15 12:29   ` AW: " Wenzel, Marco
2021-02-15 16:48     ` George McCollister
2021-02-17 13:14       ` AW: " Wenzel, Marco
2021-02-17 17:41         ` George McCollister
2021-02-18 15:01           ` [PATCH] net: hsr: add support for EntryForgetTime Marco Wenzel
2021-02-18 17:06             ` George McCollister
2021-02-19  8:27               ` AW: " Wenzel, Marco
2021-02-19 13:40                 ` George McCollister
2021-02-17 19:51         ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC1ztKr/bpmc71Xh@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Marco.Wenzel@a-eberle.de \
    --cc=george.mccollister@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox