From: Marcelo Leitner <mleitner@redhat.com>
To: Louis Peens <louis.peens@corigine.com>
Cc: wenxu <wenxu@ucloud.cn>, Ilya Maximets <i.maximets@ovn.org>,
"ovs-dev@openvswitch.org" <ovs-dev@openvswitch.org>,
Paul Blakey <paulb@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Yinjun Zhang <yinjun.zhang@corigine.com>,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [ovs-dev] tc-conntrack: inconsistent behaviour with icmpv6
Date: Fri, 26 Mar 2021 13:58:04 -0300 [thread overview]
Message-ID: <YF4SnCaDTfKcVImr@horizon.localdomain> (raw)
In-Reply-To: <c32bac8a-8127-1bf1-3b3e-13afdfbe7379@corigine.com>
On Tue, Mar 16, 2021 at 05:12:22PM +0200, Louis Peens wrote:
> So in the end I think there are two problems - the on you identified with only checking
> the mask in commit 1bcc51ac0731. And then the second bigger one is that the behaviour
> differs depending on whether the recirc upcall is after the a rule installed in tc
> or a rule installed in ovs, as Marcelo mentioned.
Hi Louis,
Not sure if you noticed but both fixes landed in upstream kernel
already.
That's basically:
afa536d8405a ("net/sched: cls_flower: fix only mask bit check in the
validate_ct_state")
d29334c15d33 ("net/sched: act_api: fix miss set post_ct for ovs after
do conntrack in act_ct")
If testing again, it's probably better if you use the latest one.
Thanks,
Marcelo
next prev parent reply other threads:[~2021-03-26 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 7:51 [ovs-dev] tc-conntrack: inconsistent behaviour with icmpv6 Louis Peens
2021-03-10 11:06 ` Ilya Maximets
2021-03-12 22:06 ` Marcelo Leitner
[not found] ` <58820355-7337-d51b-32dd-be944600832d@corigine.com>
2021-03-15 15:50 ` Louis Peens
2021-03-16 7:00 ` wenxu
2021-03-16 15:12 ` Louis Peens
2021-03-26 16:58 ` Marcelo Leitner [this message]
2021-03-26 18:03 ` Louis Peens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF4SnCaDTfKcVImr@horizon.localdomain \
--to=mleitner@redhat.com \
--cc=i.maximets@ovn.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=ovs-dev@openvswitch.org \
--cc=paulb@nvidia.com \
--cc=simon.horman@netronome.com \
--cc=wenxu@ucloud.cn \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox