Re: sunxi H5 DTB fix for realtek regression

["Clément Bœsch" <u@pkh.me>]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Mon, Aug 30, 2021 at 03:51:25PM +0200, Andrew Lunn wrote:
[...]
> > I'm sorry for not sending a proper patch: I unfortunately have very little
> > clue about what I'm doing here so it's very hard for me to elaborate a
> > proper commit description.
> 
> Hi Clément
> 
> You are not too far away from a proper patch. I can either guide you,
> if you want to learn, or the allwinner maintainer can probably take
> your work and finish it off.

See attached patch, heavily based on other commits.

Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might
affect other hardware as well. I don't know how one is supposed to check
that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a
quick internet search shows that it's using a RTL8211E¹)

The grep returns 231 occurences... A lot of other boards might have a
broken network right now.

[1]: http://nanopi.io/nanopi-a64.html

-- 
Clément B.

[-- Attachment #2: 0001-arm64-dts-sun50i-h5-NanoPI-Neo-2-phy-mode-rgmii-id.patch --]
[-- Type: text/plain, Size: 1188 bytes --]

From 771f3ad9f8749dd29039a623b25feb818f182104 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <u@pkh.me>
Date: Mon, 30 Aug 2021 16:28:08 +0200
Subject: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id

Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") network is broken on the NanoPi Neo 2.

This patch changes the phy-mode to use internal delays both for RX and
TX as has been done for other boards affected by the same commit.

Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
index 02f8e72f0cad..05486cccee1c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
@@ -75,7 +75,7 @@ &emac {
 	pinctrl-0 = <&emac_rgmii_pins>;
 	phy-supply = <&reg_gmac_3v3>;
 	phy-handle = <&ext_rgmii_phy>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
 
-- 
2.33.0