* [PATCH] net: phy: fix error check return value of phy_read()
@ 2022-04-19 1:44 cgel.zte
2022-04-19 12:07 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: cgel.zte @ 2022-04-19 1:44 UTC (permalink / raw)
To: f.fainelli, bcm-kernel-feedback-list, andrew
Cc: hkallweit1, linux, davem, kuba, pabeni, netdev, linux-kernel,
Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
phy_read() returns a negative number if there's an error, but the
error-checking code in the bcm87xx driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/net/phy/bcm87xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
index 313563482690..e62b53718010 100644
--- a/drivers/net/phy/bcm87xx.c
+++ b/drivers/net/phy/bcm87xx.c
@@ -146,7 +146,7 @@ static int bcm87xx_config_intr(struct phy_device *phydev)
if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
err = phy_read(phydev, BCM87XX_LASI_STATUS);
- if (err)
+ if (err < 0)
return err;
reg |= 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: fix error check return value of phy_read()
2022-04-19 1:44 [PATCH] net: phy: fix error check return value of phy_read() cgel.zte
@ 2022-04-19 12:07 ` Andrew Lunn
2022-04-25 15:55 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2022-04-19 12:07 UTC (permalink / raw)
To: cgel.zte
Cc: f.fainelli, bcm-kernel-feedback-list, hkallweit1, linux, davem,
kuba, pabeni, netdev, linux-kernel, Lv Ruyi, Zeal Robot
On Tue, Apr 19, 2022 at 01:44:39AM +0000, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the bcm87xx driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/net/phy/bcm87xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
> index 313563482690..e62b53718010 100644
> --- a/drivers/net/phy/bcm87xx.c
> +++ b/drivers/net/phy/bcm87xx.c
> @@ -146,7 +146,7 @@ static int bcm87xx_config_intr(struct phy_device *phydev)
>
> if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
> err = phy_read(phydev, BCM87XX_LASI_STATUS);
> - if (err)
> + if (err < 0)
> return err;
This should probably have a Fixes: tag, and be for net, not next-next.
Please read the netdev FAQ about the trees, and submittinng fixes for
netdev.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: fix error check return value of phy_read()
2022-04-19 12:07 ` Andrew Lunn
@ 2022-04-25 15:55 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-04-25 15:55 UTC (permalink / raw)
To: Andrew Lunn, cgel.zte
Cc: f.fainelli, bcm-kernel-feedback-list, hkallweit1, linux, davem,
kuba, pabeni, netdev, linux-kernel, Lv Ruyi, Zeal Robot
On 4/19/2022 5:07 AM, Andrew Lunn wrote:
> On Tue, Apr 19, 2022 at 01:44:39AM +0000, cgel.zte@gmail.com wrote:
>> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>>
>> phy_read() returns a negative number if there's an error, but the
>> error-checking code in the bcm87xx driver's config_intr function
>> triggers if phy_read() returns non-zero. Correct that.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>> ---
>> drivers/net/phy/bcm87xx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
>> index 313563482690..e62b53718010 100644
>> --- a/drivers/net/phy/bcm87xx.c
>> +++ b/drivers/net/phy/bcm87xx.c
>> @@ -146,7 +146,7 @@ static int bcm87xx_config_intr(struct phy_device *phydev)
>>
>> if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
>> err = phy_read(phydev, BCM87XX_LASI_STATUS);
>> - if (err)
>> + if (err < 0)
>> return err;
>
> This should probably have a Fixes: tag, and be for net, not next-next.
> Please read the netdev FAQ about the trees, and submittinng fixes for
> netdev.
Yes, it should be:
Fixes: 15772e4ddf3f ("net: phy: broadcom: remove use of ack_interrupt()")
Also, please subject this change properly with:
net: phy: bcm87xx: Added missing error checking
Thank you
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-25 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-19 1:44 [PATCH] net: phy: fix error check return value of phy_read() cgel.zte
2022-04-19 12:07 ` Andrew Lunn
2022-04-25 15:55 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox