From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Jiri Pirko <jiri@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2-next 2/2] devlink: remove dl_argv_parse_put
Date: Fri, 19 Aug 2022 10:27:03 +0200 [thread overview]
Message-ID: <Yv9JV52+COsNcyVU@nanopsycho> (raw)
In-Reply-To: <20220818211521.169569-3-jacob.e.keller@intel.com>
Thu, Aug 18, 2022 at 11:15:21PM CEST, jacob.e.keller@intel.com wrote:
>The dl_argv_parse_put function is used to extract arguments from the
>command line and convert them to the appropriate netlink attributes. This
>function is a combination of calling dl_argv_parse and dl_put_opts.
>
>A future change is going to refactor dl_argv_parse to check the kernel's
>netlink policy for the command. This requires issuing another netlink
>message which requires calling dl_argv_parse before
>mnlu_gen_socket_cmd_prepare. Otherwise, the get policy command issued in
>dl_argv_parse would overwrite the prepared buffer.
>
>This conflicts with dl_argv_parse_put which requires being called after
>mnlu_gen_socket_cmd_prepare.
>
>Remove dl_argv_parse_put and replace it with appropriate calls to
>dl_argv_parse and dl_put_opts. This allows us to ensure dl_argv_parse is
>called before mnlu_gen_socket_cmd_prepare while dl_put_opts is called
>afterwards.
>
>Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2022-08-19 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:15 [iproute2-next 0/2] devlink: remove dl_argv_parse_put Jacob Keller
2022-08-18 21:15 ` [iproute2-next 1/2] devlink: use dl_no_arg instead of checking dl_argc == 0 Jacob Keller
2022-08-19 8:26 ` Jiri Pirko
2022-08-18 21:15 ` [iproute2-next 2/2] devlink: remove dl_argv_parse_put Jacob Keller
2022-08-19 8:27 ` Jiri Pirko [this message]
2022-08-19 8:27 ` [iproute2-next 0/2] " Jiri Pirko
2022-08-24 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv9JV52+COsNcyVU@nanopsycho \
--to=jiri@resnulli.us \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox