From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Jiri Pirko <jiri@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2-next 0/2] devlink: remove dl_argv_parse_put
Date: Fri, 19 Aug 2022 10:27:28 +0200 [thread overview]
Message-ID: <Yv9JcA/Fil0y1c6p@nanopsycho> (raw)
In-Reply-To: <20220818211521.169569-1-jacob.e.keller@intel.com>
Thu, Aug 18, 2022 at 11:15:19PM CEST, jacob.e.keller@intel.com wrote:
>This series removes the dl_argv_parse_put function which both parses the
>command line arguments and places them into the netlink header.
>
>This was originally sent as an RFC at
>https://lore.kernel.org/netdev/20220805234155.2878160-1-jacob.e.keller@intel.com/
>
>Since there is some ongoing work around policy code being generated from
>YAML, I thought it best to wait on the devlink policy portion of this series
>for now.
>
>Jiri mentioned he wanted to base some work on top of this, so I am sending
>just the cleanup patches.
>
>The primary motivation for this is due to the fact that dl_argv_parse_put
>requires a netlink header, meaning a command must have already been
>prepared. This prevents addition of a different netlink command to get the
>policy data, and thus prevents us from using this variant while checking
>netlink policy.
Thanks Jacob!
next prev parent reply other threads:[~2022-08-19 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:15 [iproute2-next 0/2] devlink: remove dl_argv_parse_put Jacob Keller
2022-08-18 21:15 ` [iproute2-next 1/2] devlink: use dl_no_arg instead of checking dl_argc == 0 Jacob Keller
2022-08-19 8:26 ` Jiri Pirko
2022-08-18 21:15 ` [iproute2-next 2/2] devlink: remove dl_argv_parse_put Jacob Keller
2022-08-19 8:27 ` Jiri Pirko
2022-08-19 8:27 ` Jiri Pirko [this message]
2022-08-24 16:00 ` [iproute2-next 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv9JcA/Fil0y1c6p@nanopsycho \
--to=jiri@resnulli.us \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox