* [PATCH net] tipc: fix shift wrapping bug in map_get()
@ 2022-08-31 14:47 Dan Carpenter
2022-09-02 11:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-08-31 14:47 UTC (permalink / raw)
To: Jon Maloy
Cc: Ying Xue, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, tipc-discussion, kernel-janitors
There is a shift wrapping bug in this code so anything thing above
31 will return false.
Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I have no idea why I didn't fix this back in 2016 when I fixed map_set().
net/tipc/monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/monitor.c b/net/tipc/monitor.c
index 2f4d23238a7e..9618e4429f0f 100644
--- a/net/tipc/monitor.c
+++ b/net/tipc/monitor.c
@@ -160,7 +160,7 @@ static void map_set(u64 *up_map, int i, unsigned int v)
static int map_get(u64 up_map, int i)
{
- return (up_map & (1 << i)) >> i;
+ return (up_map & (1ULL << i)) >> i;
}
static struct tipc_peer *peer_prev(struct tipc_peer *peer)
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] tipc: fix shift wrapping bug in map_get()
2022-08-31 14:47 [PATCH net] tipc: fix shift wrapping bug in map_get() Dan Carpenter
@ 2022-09-02 11:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-02 11:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: jmaloy, ying.xue, davem, edumazet, kuba, pabeni, netdev,
tipc-discussion, kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 31 Aug 2022 17:47:56 +0300 you wrote:
> There is a shift wrapping bug in this code so anything thing above
> 31 will return false.
>
> Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I have no idea why I didn't fix this back in 2016 when I fixed map_set().
>
> [...]
Here is the summary with links:
- [net] tipc: fix shift wrapping bug in map_get()
https://git.kernel.org/netdev/net/c/e2b224abd9bf
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-02 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-31 14:47 [PATCH net] tipc: fix shift wrapping bug in map_get() Dan Carpenter
2022-09-02 11:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox