From: Cong Wang <xiyou.wangcong@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Davide Caratti <dcaratti@redhat.com>,
Simon Horman <horms@kernel.org>, Shuang Li <shuali@redhat.com>
Subject: Re: [PATCHv2 net] net: sched: fix erspan_opt settings in cls_flower
Date: Tue, 3 Dec 2024 16:19:14 -0800 [thread overview]
Message-ID: <Z0+gAnxvkIEhmBc5@pop-os.localdomain> (raw)
In-Reply-To: <981381d3d1aaa4f81619145180e06338af487a42.1733152898.git.lucien.xin@gmail.com>
On Mon, Dec 02, 2024 at 10:21:38AM -0500, Xin Long wrote:
> When matching erspan_opt in cls_flower, only the (version, dir, hwid)
> fields are relevant. However, in fl_set_erspan_opt() it initializes
> all bits of erspan_opt and its mask to 1. This inadvertently requires
> packets to match not only the (version, dir, hwid) fields but also the
> other fields that are unexpectedly set to 1.
>
> This patch resolves the issue by ensuring that only the (version, dir,
> hwid) fields are configured in fl_set_erspan_opt(), leaving the other
> fields to 0 in erspan_opt.
>
> Fixes: 79b1011cb33d ("net: sched: allow flower to match erspan options")
> Reported-by: Shuang Li <shuali@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Looking forward to your selftest. :)
Thanks.
next prev parent reply other threads:[~2024-12-04 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 15:21 [PATCHv2 net] net: sched: fix erspan_opt settings in cls_flower Xin Long
2024-12-04 0:19 ` Cong Wang [this message]
2024-12-04 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0+gAnxvkIEhmBc5@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuali@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox