[PATCH net-next v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()

[PATCH net-next v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()

[Ted Chen]

Remove the two unnecessary comments around vxlan_rcv() and
vxlan_err_lookup(), which indicate that the callers are from
net/ipv{4,6}/udp.c. These callers are trivial to find. Additionally, the
comment for vxlan_rcv() missed that the caller could also be from
net/ipv6/udp.c.

Suggested-by: Nikolay Aleksandrov <razor@blackwall.org>
Suggested-by: Ido Schimmel <idosch@idosch.org>
Signed-off-by: Ted Chen <znscnchen@gmail.com>
---
v2: removed the comments for vxlan_rcv() and vxlan_err_lookup().
    (Nikolay, Ido)
v1: https://lore.kernel.org/all/20250205114448.113966-1-znscnchen@gmail.com
---
 drivers/net/vxlan/vxlan_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index ece5415f9013..44eba7aa831a 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -1670,7 +1670,6 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
 	return err <= 1;
 }
 
-/* Callback from net/ipv4/udp.c to receive packets */
 static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
 {
 	struct vxlan_vni_node *vninode = NULL;
@@ -1840,7 +1839,6 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
 	return 0;
 }
 
-/* Callback from net/ipv{4,6}/udp.c to check that we have a VNI for errors */
 static int vxlan_err_lookup(struct sock *sk, struct sk_buff *skb)
 {
 	struct vxlan_dev *vxlan;
-- 
2.39.2

Re: [PATCH net-next v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()

[Nikolay Aleksandrov]

On 2/6/25 16:00, Ted Chen wrote:
> Remove the two unnecessary comments around vxlan_rcv() and
> vxlan_err_lookup(), which indicate that the callers are from
> net/ipv{4,6}/udp.c. These callers are trivial to find. Additionally, the
> comment for vxlan_rcv() missed that the caller could also be from
> net/ipv6/udp.c.
> 
> Suggested-by: Nikolay Aleksandrov <razor@blackwall.org>
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> ---
> v2: removed the comments for vxlan_rcv() and vxlan_err_lookup().
>     (Nikolay, Ido)
> v1: https://lore.kernel.org/all/20250205114448.113966-1-znscnchen@gmail.com
> ---
>  drivers/net/vxlan/vxlan_core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index ece5415f9013..44eba7aa831a 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1670,7 +1670,6 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
>  	return err <= 1;
>  }
>  
> -/* Callback from net/ipv4/udp.c to receive packets */
>  static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
>  {
>  	struct vxlan_vni_node *vninode = NULL;
> @@ -1840,7 +1839,6 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
>  	return 0;
>  }
>  
> -/* Callback from net/ipv{4,6}/udp.c to check that we have a VNI for errors */
>  static int vxlan_err_lookup(struct sock *sk, struct sk_buff *skb)
>  {
>  	struct vxlan_dev *vxlan;

LGTM,
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>

Re: [PATCH net-next v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()

[Ido Schimmel]

On Thu, Feb 06, 2025 at 10:00:02PM +0800, Ted Chen wrote:
> Remove the two unnecessary comments around vxlan_rcv() and
> vxlan_err_lookup(), which indicate that the callers are from
> net/ipv{4,6}/udp.c. These callers are trivial to find. Additionally, the
> comment for vxlan_rcv() missed that the caller could also be from
> net/ipv6/udp.c.
> 
> Suggested-by: Nikolay Aleksandrov <razor@blackwall.org>
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Ted Chen <znscnchen@gmail.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH net-next v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  6 Feb 2025 22:00:02 +0800 you wrote:
> Remove the two unnecessary comments around vxlan_rcv() and
> vxlan_err_lookup(), which indicate that the callers are from
> net/ipv{4,6}/udp.c. These callers are trivial to find. Additionally, the
> comment for vxlan_rcv() missed that the caller could also be from
> net/ipv6/udp.c.
> 
> Suggested-by: Nikolay Aleksandrov <razor@blackwall.org>
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()
    https://git.kernel.org/netdev/net-next/c/a494d1512c7c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html