From: Joe Damato <jdamato@fastly.com>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] netpoll: Eliminate redundant assignment
Date: Wed, 19 Mar 2025 13:10:27 -0700 [thread overview]
Message-ID: <Z9sks79ntumxlsjP@LQ3V64L9R2> (raw)
In-Reply-To: <20250319-netpoll_nit-v1-1-a7faac5cbd92@debian.org>
On Wed, Mar 19, 2025 at 10:02:44AM -0700, Breno Leitao wrote:
> The assignment of zero to udph->check is unnecessary as it is
> immediately overwritten in the subsequent line. Remove the redundant
> assignment.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/core/netpoll.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index 3cc3eae9def30..4e1dba572f5ac 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -433,7 +433,6 @@ int netpoll_send_udp(struct netpoll *np, const char *msg, int len)
> udph->len = htons(udp_len);
>
> if (np->ipv6) {
> - udph->check = 0;
> udph->check = csum_ipv6_magic(&np->local_ip.in6,
> &np->remote_ip.in6,
> udp_len, IPPROTO_UDP,
>
> ---
> base-commit: 23c9ff659140f97d44bf6fb59f89526a168f2b86
> change-id: 20250319-netpoll_nit-6390753708bc
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-03-19 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 17:02 [PATCH net-next] netpoll: Eliminate redundant assignment Breno Leitao
2025-03-19 20:10 ` Joe Damato [this message]
2025-03-24 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9sks79ntumxlsjP@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox