* [PATCH net-next] netpoll: Eliminate redundant assignment
@ 2025-03-19 17:02 Breno Leitao
2025-03-19 20:10 ` Joe Damato
2025-03-24 20:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Breno Leitao @ 2025-03-19 17:02 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman
Cc: netdev, linux-kernel, Breno Leitao
The assignment of zero to udph->check is unnecessary as it is
immediately overwritten in the subsequent line. Remove the redundant
assignment.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
net/core/netpoll.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 3cc3eae9def30..4e1dba572f5ac 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -433,7 +433,6 @@ int netpoll_send_udp(struct netpoll *np, const char *msg, int len)
udph->len = htons(udp_len);
if (np->ipv6) {
- udph->check = 0;
udph->check = csum_ipv6_magic(&np->local_ip.in6,
&np->remote_ip.in6,
udp_len, IPPROTO_UDP,
---
base-commit: 23c9ff659140f97d44bf6fb59f89526a168f2b86
change-id: 20250319-netpoll_nit-6390753708bc
Best regards,
--
Breno Leitao <leitao@debian.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netpoll: Eliminate redundant assignment
2025-03-19 17:02 [PATCH net-next] netpoll: Eliminate redundant assignment Breno Leitao
@ 2025-03-19 20:10 ` Joe Damato
2025-03-24 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Joe Damato @ 2025-03-19 20:10 UTC (permalink / raw)
To: Breno Leitao
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, netdev, linux-kernel
On Wed, Mar 19, 2025 at 10:02:44AM -0700, Breno Leitao wrote:
> The assignment of zero to udph->check is unnecessary as it is
> immediately overwritten in the subsequent line. Remove the redundant
> assignment.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/core/netpoll.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index 3cc3eae9def30..4e1dba572f5ac 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -433,7 +433,6 @@ int netpoll_send_udp(struct netpoll *np, const char *msg, int len)
> udph->len = htons(udp_len);
>
> if (np->ipv6) {
> - udph->check = 0;
> udph->check = csum_ipv6_magic(&np->local_ip.in6,
> &np->remote_ip.in6,
> udp_len, IPPROTO_UDP,
>
> ---
> base-commit: 23c9ff659140f97d44bf6fb59f89526a168f2b86
> change-id: 20250319-netpoll_nit-6390753708bc
Reviewed-by: Joe Damato <jdamato@fastly.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netpoll: Eliminate redundant assignment
2025-03-19 17:02 [PATCH net-next] netpoll: Eliminate redundant assignment Breno Leitao
2025-03-19 20:10 ` Joe Damato
@ 2025-03-24 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-24 20:50 UTC (permalink / raw)
To: Breno Leitao; +Cc: davem, edumazet, kuba, pabeni, horms, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 19 Mar 2025 10:02:44 -0700 you wrote:
> The assignment of zero to udph->check is unnecessary as it is
> immediately overwritten in the subsequent line. Remove the redundant
> assignment.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/core/netpoll.c | 1 -
> 1 file changed, 1 deletion(-)
>
> [...]
Here is the summary with links:
- [net-next] netpoll: Eliminate redundant assignment
https://git.kernel.org/netdev/net-next/c/f1fce08e63fe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-24 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-19 17:02 [PATCH net-next] netpoll: Eliminate redundant assignment Breno Leitao
2025-03-19 20:10 ` Joe Damato
2025-03-24 20:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox