Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next] team: add __exit modifier to team_nl_fini()
@ 2023-08-04 11:35 Zhengchao Shao
  2023-08-05 11:52 ` Simon Horman
  2023-08-07  2:38 ` Hangbin Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Zhengchao Shao @ 2023-08-04 11:35 UTC (permalink / raw)
  To: netdev, davem, edumazet, kuba, pabeni
  Cc: jiri, weiyongjun1, yuehaibing, shaozhengchao

team_nl_fini is only called when the module exits, so add the __exit
modifier to it.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 drivers/net/team/team.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index bc50fc3f6913..e4fe70a71b40 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2892,7 +2892,7 @@ static int __init team_nl_init(void)
 	return genl_register_family(&team_nl_family);
 }
 
-static void team_nl_fini(void)
+static void __exit team_nl_fini(void)
 {
 	genl_unregister_family(&team_nl_family);
 }
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] team: add __exit modifier to team_nl_fini()
  2023-08-04 11:35 [PATCH net-next] team: add __exit modifier to team_nl_fini() Zhengchao Shao
@ 2023-08-05 11:52 ` Simon Horman
  2023-08-07  2:38 ` Hangbin Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-08-05 11:52 UTC (permalink / raw)
  To: Zhengchao Shao
  Cc: netdev, davem, edumazet, kuba, pabeni, jiri, weiyongjun1,
	yuehaibing

On Fri, Aug 04, 2023 at 07:35:57PM +0800, Zhengchao Shao wrote:
> team_nl_fini is only called when the module exits, so add the __exit
> modifier to it.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] team: add __exit modifier to team_nl_fini()
  2023-08-04 11:35 [PATCH net-next] team: add __exit modifier to team_nl_fini() Zhengchao Shao
  2023-08-05 11:52 ` Simon Horman
@ 2023-08-07  2:38 ` Hangbin Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Hangbin Liu @ 2023-08-07  2:38 UTC (permalink / raw)
  To: Zhengchao Shao
  Cc: netdev, davem, edumazet, kuba, pabeni, jiri, weiyongjun1,
	yuehaibing

On Fri, Aug 04, 2023 at 07:35:57PM +0800, Zhengchao Shao wrote:
> team_nl_fini is only called when the module exits, so add the __exit
> modifier to it.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>  drivers/net/team/team.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> index bc50fc3f6913..e4fe70a71b40 100644
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -2892,7 +2892,7 @@ static int __init team_nl_init(void)
>  	return genl_register_family(&team_nl_family);
>  }
>  
> -static void team_nl_fini(void)
> +static void __exit team_nl_fini(void)
>  {
>  	genl_unregister_family(&team_nl_family);
>  }
> -- 
> 2.34.1

Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-07  2:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 11:35 [PATCH net-next] team: add __exit modifier to team_nl_fini() Zhengchao Shao
2023-08-05 11:52 ` Simon Horman
2023-08-07  2:38 ` Hangbin Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox