[patch net-next] devlink: add missing unregister linecard notification

[patch net-next] devlink: add missing unregister linecard notification

[Jiri Pirko]

From: Jiri Pirko <jiri@nvidia.com>

Cited fixes commit introduced linecard notifications for register,
however it didn't add them for unregister. Fix that by adding them.

Fixes: c246f9b5fd61 ("devlink: add support to create line card and expose to user")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
 net/devlink/leftover.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
index c26c63275b0b..e7f76cc58533 100644
--- a/net/devlink/leftover.c
+++ b/net/devlink/leftover.c
@@ -6630,6 +6630,7 @@ void devlink_notify_unregister(struct devlink *devlink)
 	struct devlink_param_item *param_item;
 	struct devlink_trap_item *trap_item;
 	struct devlink_port *devlink_port;
+	struct devlink_linecard *linecard;
 	struct devlink_rate *rate_node;
 	struct devlink_region *region;
 	unsigned long port_index;
@@ -6658,6 +6659,8 @@ void devlink_notify_unregister(struct devlink *devlink)
 
 	xa_for_each(&devlink->ports, port_index, devlink_port)
 		devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_DEL);
+	list_for_each_entry_reverse(linecard, &devlink->linecard_list, list)
+		devlink_linecard_notify(linecard, DEVLINK_CMD_LINECARD_DEL);
 	devlink_notify(devlink, DEVLINK_CMD_DEL);
 }
 
-- 
2.41.0

Re: [patch net-next] devlink: add missing unregister linecard notification

[Simon Horman]

On Thu, Aug 17, 2023 at 02:52:40PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> Cited fixes commit introduced linecard notifications for register,
> however it didn't add them for unregister. Fix that by adding them.
> 
> Fixes: c246f9b5fd61 ("devlink: add support to create line card and expose to user")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [patch net-next] devlink: add missing unregister linecard notification

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 17 Aug 2023 14:52:40 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> Cited fixes commit introduced linecard notifications for register,
> however it didn't add them for unregister. Fix that by adding them.
> 
> Fixes: c246f9b5fd61 ("devlink: add support to create line card and expose to user")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next] devlink: add missing unregister linecard notification
    https://git.kernel.org/netdev/net/c/2ebbc9752d06

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [patch net-next] devlink: add missing unregister linecard notification

[Jiri Pirko]

Kuba, do you plan to merge net into net-next any time soon? I have
another patchset depending on this.

Btw, I aimed this to net-next on purpose, in net it does not make much
sense imho.

Thanks!

Thu, Aug 17, 2023 at 02:52:40PM CEST, jiri@resnulli.us wrote:
>From: Jiri Pirko <jiri@nvidia.com>
>
>Cited fixes commit introduced linecard notifications for register,
>however it didn't add them for unregister. Fix that by adding them.
>
>Fixes: c246f9b5fd61 ("devlink: add support to create line card and expose to user")
>Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>---
> net/devlink/leftover.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
>index c26c63275b0b..e7f76cc58533 100644
>--- a/net/devlink/leftover.c
>+++ b/net/devlink/leftover.c
>@@ -6630,6 +6630,7 @@ void devlink_notify_unregister(struct devlink *devlink)
> 	struct devlink_param_item *param_item;
> 	struct devlink_trap_item *trap_item;
> 	struct devlink_port *devlink_port;
>+	struct devlink_linecard *linecard;
> 	struct devlink_rate *rate_node;
> 	struct devlink_region *region;
> 	unsigned long port_index;
>@@ -6658,6 +6659,8 @@ void devlink_notify_unregister(struct devlink *devlink)
> 
> 	xa_for_each(&devlink->ports, port_index, devlink_port)
> 		devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_DEL);
>+	list_for_each_entry_reverse(linecard, &devlink->linecard_list, list)
>+		devlink_linecard_notify(linecard, DEVLINK_CMD_LINECARD_DEL);
> 	devlink_notify(devlink, DEVLINK_CMD_DEL);
> }
> 
>-- 
>2.41.0
>

Re: [patch net-next] devlink: add missing unregister linecard notification

[Paolo Abeni]

Hi,

On Thu, 2023-08-24 at 10:09 +0200, Jiri Pirko wrote:
> Kuba, do you plan to merge net into net-next any time soon? I have
> another patchset depending on this.
> 
> Btw, I aimed this to net-next on purpose, in net it does not make much
> sense imho.

That patch has been applied to net.

Today we have sent the PR for -net to Linus. Hopefully it should be
merged into vanilla soon, and shortly after that, net will be merged
back into net-next. 

Usually that happen by the end of the day (european time).

Cheers,

Paolo