Re: [patch net-next] tools: ynl-gen: lift type requirement for attribute subsets

[Jiri Pirko <jiri@resnulli.us>]

Thu, Sep 28, 2023 at 12:15:22PM CEST, pabeni@redhat.com wrote:
>On Tue, 2023-09-19 at 16:21 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>> 
>> In case an attribute is used in a subset, the type has to be currently
>> specified. As the attribute is already defined in the original set, this
>> is a redundant information in yaml file, moreover, may lead to
>> inconsistencies.
>> 
>> Example:
>> attribute-sets:
>>     ...
>>     name: pin
>>     enum-name: dpll_a_pin
>>     attributes:
>>       ...
>>       -
>>         name: parent-id
>>         type: u32
>>       ...
>>   -
>>     name: pin-parent-device
>>     subset-of: pin
>>     attributes:
>>       -
>>         name: parent-id
>>         type: u32             <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>> 
>> Remove the requirement from schema files to specify the "type" and add
>> check and bail out if "type" is not set.
>> 
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>
>What about updating accordingly the existing specs? They are used as
>references, I think it would be better if the info there would be
>consistent.

Okay, will check that out. I will try to update some.


>
>I think the tool still allows writing something alike:
>
>    attributes:
>      ...
>      -
>        name: parent-id
>        type: u32
>      ...
>  -
>    name: pin-parent-device
>    subset-of: pin
>    attributes:
>      -
>        name: parent-id
>        type: string
>
>(mismatching types). What about adding an explicit test to prevent
>specifying again the types for already defined attributes?

Good point. Will check.


>
>Cheers,
>
>Paolo
>