From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, gal@nvidia.com
Subject: Re: [patch net-next] devlink: don't take instance lock for nested handle put
Date: Mon, 9 Oct 2023 17:37:27 +0200 [thread overview]
Message-ID: <ZSQeNxmoual7ewcl@nanopsycho> (raw)
In-Reply-To: <20231009081532.07e902d4@kernel.org>
Mon, Oct 09, 2023 at 05:15:32PM CEST, kuba@kernel.org wrote:
>On Sat, 7 Oct 2023 12:17:31 +0200 Jiri Pirko wrote:
>>> Isn't the PF driver processing the "FW events"? A is PF here, and B
>>> is SF, are you saying that the PF devlink instance can be completely
>>> removed (not just unregistered, freed) before the SF instance is
>>> unregistered?
>>
>> Kernel-wise, yes. The FW probably holds necessary resource until SF goes
>> away.
>
>I think kernel assuming that this should not happen and requiring
>the PF driver to work around potentially stupid FW designs should
>be entirely without our rights.
But why is it stupid? The SF may be spawned on the same host, but it
could be spawned on another one. The FW creates SF internally and shows
that to the kernel. Symetrically, the FW is asked to remove SF and it
tells to the host that the SF is going away. Flows have to go
through FW.
next prev parent reply other threads:[~2023-10-09 15:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 7:43 [patch net-next] devlink: don't take instance lock for nested handle put Jiri Pirko
2023-10-06 1:30 ` Jakub Kicinski
2023-10-06 7:22 ` Jiri Pirko
2023-10-06 14:48 ` Jakub Kicinski
2023-10-06 17:07 ` Jiri Pirko
2023-10-06 22:14 ` Jakub Kicinski
2023-10-07 10:17 ` Jiri Pirko
2023-10-09 15:15 ` Jakub Kicinski
2023-10-09 15:37 ` Jiri Pirko [this message]
2023-10-09 16:31 ` Jakub Kicinski
2023-10-10 7:31 ` Jiri Pirko
2023-10-10 14:52 ` Jakub Kicinski
2023-10-10 15:56 ` Jiri Pirko
2023-10-10 18:16 ` Jakub Kicinski
2023-10-11 13:34 ` Jiri Pirko
2023-10-12 0:20 ` Jakub Kicinski
2023-10-12 6:14 ` Jiri Pirko
2023-10-13 15:39 ` Jakub Kicinski
2023-10-13 17:07 ` Jiri Pirko
2023-10-13 20:01 ` Jakub Kicinski
2023-10-15 11:12 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSQeNxmoual7ewcl@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox