* [PATCH net-next v4 0/2] ethtool: Add link mode maps for forced speeds
@ 2023-10-11 13:13 Pawel Chmielewski
2023-10-11 13:13 ` [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps Pawel Chmielewski
2023-10-11 13:13 ` [PATCH net-next v4 2/2] ice: Refactor finding advertised link speed Pawel Chmielewski
0 siblings, 2 replies; 6+ messages in thread
From: Pawel Chmielewski @ 2023-10-11 13:13 UTC (permalink / raw)
To: netdev
Cc: intel-wired-lan, andrew, aelior, manishc, horms, vladimir.oltean,
pabeni, davem, edumazet, jdamato, d-tatianin, kuba,
Pawel Chmielewski
The following patch set was initially a part of [1]. As the purpose of
the original series was to add the support of the new hardware to the
intel ice driver, the refactoring of advertised link modes mapping was
extracted to a new set.
The patch set adds a common mechanism for mapping Ethtool forced speeds
with Ethtool supported link modes, which can be used in drivers code.
[1] https://lore.kernel.org/netdev/20230823180633.2450617-1-pawel.chmielewski@intel.com
Changelog:
v3->v4:
Moved the macro for setting fields into the common header file
v2->v3:
Fixed whitespaces, added missing line at end of file
v1->v2:
Fixed formatting, typo, moved declaration of iterator to loop line.
Paul Greenwalt (1):
ethtool: Add forced speed to supported link modes maps
Pawel Chmielewski (1):
ice: Refactor finding advertised link speed
drivers/net/ethernet/intel/ice/ice.h | 1 +
drivers/net/ethernet/intel/ice/ice_ethtool.c | 193 ++++++++++++------
drivers/net/ethernet/intel/ice/ice_main.c | 2 +
.../net/ethernet/qlogic/qede/qede_ethtool.c | 46 ++---
include/linux/ethtool.h | 27 +++
net/ethtool/ioctl.c | 13 ++
6 files changed, 183 insertions(+), 99 deletions(-)
--
2.37.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps
2023-10-11 13:13 [PATCH net-next v4 0/2] ethtool: Add link mode maps for forced speeds Pawel Chmielewski
@ 2023-10-11 13:13 ` Pawel Chmielewski
2023-10-11 15:12 ` Jiri Pirko
2023-10-11 13:13 ` [PATCH net-next v4 2/2] ice: Refactor finding advertised link speed Pawel Chmielewski
1 sibling, 1 reply; 6+ messages in thread
From: Pawel Chmielewski @ 2023-10-11 13:13 UTC (permalink / raw)
To: netdev
Cc: intel-wired-lan, andrew, aelior, manishc, horms, vladimir.oltean,
pabeni, davem, edumazet, jdamato, d-tatianin, kuba,
Paul Greenwalt, Jacob Keller, Przemek Kitszel, Pawel Chmielewski
From: Paul Greenwalt <paul.greenwalt@intel.com>
The need to map Ethtool forced speeds to Ethtool supported link modes is
common among drivers. To support this, add a common structure for forced
speed maps and a function to init them. This is solution was originally
introduced in commit 1d4e4ecccb11 ("qede: populate supported link modes
maps on module init") for qede driver.
ethtool_forced_speed_maps_init() should be called during driver init
with an array of struct ethtool_forced_speed_map to populate the mapping.
Definitions for maps themselves are left in the driver code, as the sets
of supported link modes may vary between the devices.
The qede driver was compile tested only.
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
---
.../net/ethernet/qlogic/qede/qede_ethtool.c | 46 +++++--------------
include/linux/ethtool.h | 27 +++++++++++
net/ethtool/ioctl.c | 13 ++++++
3 files changed, 52 insertions(+), 34 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 95820cf1cd6c..d4f2cd13d308 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -201,21 +201,6 @@ static const char qede_tests_str_arr[QEDE_ETHTOOL_TEST_MAX][ETH_GSTRING_LEN] = {
/* Forced speed capabilities maps */
-struct qede_forced_speed_map {
- u32 speed;
- __ETHTOOL_DECLARE_LINK_MODE_MASK(caps);
-
- const u32 *cap_arr;
- u32 arr_size;
-};
-
-#define QEDE_FORCED_SPEED_MAP(value) \
-{ \
- .speed = SPEED_##value, \
- .cap_arr = qede_forced_speed_##value, \
- .arr_size = ARRAY_SIZE(qede_forced_speed_##value), \
-}
-
static const u32 qede_forced_speed_1000[] __initconst = {
ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
ETHTOOL_LINK_MODE_1000baseKX_Full_BIT,
@@ -263,28 +248,21 @@ static const u32 qede_forced_speed_100000[] __initconst = {
ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
};
-static struct qede_forced_speed_map qede_forced_speed_maps[] __ro_after_init = {
- QEDE_FORCED_SPEED_MAP(1000),
- QEDE_FORCED_SPEED_MAP(10000),
- QEDE_FORCED_SPEED_MAP(20000),
- QEDE_FORCED_SPEED_MAP(25000),
- QEDE_FORCED_SPEED_MAP(40000),
- QEDE_FORCED_SPEED_MAP(50000),
- QEDE_FORCED_SPEED_MAP(100000),
+static struct ethtool_forced_speed_map
+ qede_forced_speed_maps[] __ro_after_init = {
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 1000),
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 10000),
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 20000),
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 25000),
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 40000),
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 50000),
+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 100000),
};
void __init qede_forced_speed_maps_init(void)
{
- struct qede_forced_speed_map *map;
- u32 i;
-
- for (i = 0; i < ARRAY_SIZE(qede_forced_speed_maps); i++) {
- map = qede_forced_speed_maps + i;
-
- linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
- map->cap_arr = NULL;
- map->arr_size = 0;
- }
+ ethtool_forced_speed_maps_init(qede_forced_speed_maps,
+ ARRAY_SIZE(qede_forced_speed_maps));
}
/* Ethtool callbacks */
@@ -564,8 +542,8 @@ static int qede_set_link_ksettings(struct net_device *dev,
const struct ethtool_link_ksettings *cmd)
{
const struct ethtool_link_settings *base = &cmd->base;
+ const struct ethtool_forced_speed_map *map;
struct qede_dev *edev = netdev_priv(dev);
- const struct qede_forced_speed_map *map;
struct qed_link_output current_link;
struct qed_link_params params;
u32 i;
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 62b61527bcc4..68d682012e9d 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -1052,4 +1052,31 @@ static inline int ethtool_mm_frag_size_min_to_add(u32 val_min, u32 *val_add,
* next string.
*/
extern __printf(2, 3) void ethtool_sprintf(u8 **data, const char *fmt, ...);
+
+/* Link mode to forced speed capabilities maps */
+struct ethtool_forced_speed_map {
+ u32 speed;
+ __ETHTOOL_DECLARE_LINK_MODE_MASK(caps);
+
+ const u32 *cap_arr;
+ u32 arr_size;
+};
+
+#define ETHTOOL_FORCED_SPEED_MAP(prefix, value) \
+{ \
+ .speed = SPEED_##value, \
+ .cap_arr = prefix##_##value, \
+ .arr_size = ARRAY_SIZE(prefix##_##value), \
+}
+
+/**
+ * ethtool_forced_speed_maps_init
+ * @maps: Pointer to an array of Ethtool forced speed map
+ * @size: Array size
+ *
+ * Initialize an array of Ethtool forced speed map to Ethtool link modes. This
+ * should be called during driver module init.
+ */
+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
+ u32 size);
#endif /* _LINUX_ETHTOOL_H */
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 0b0ce4f81c01..34507691fc9d 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -3388,3 +3388,16 @@ void ethtool_rx_flow_rule_destroy(struct ethtool_rx_flow_rule *flow)
kfree(flow);
}
EXPORT_SYMBOL(ethtool_rx_flow_rule_destroy);
+
+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
+ u32 size)
+{
+ for (u32 i = 0; i < size; i++) {
+ struct ethtool_forced_speed_map *map = &maps[i];
+
+ linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
+ map->cap_arr = NULL;
+ map->arr_size = 0;
+ }
+}
+EXPORT_SYMBOL(ethtool_forced_speed_maps_init);
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next v4 2/2] ice: Refactor finding advertised link speed
2023-10-11 13:13 [PATCH net-next v4 0/2] ethtool: Add link mode maps for forced speeds Pawel Chmielewski
2023-10-11 13:13 ` [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps Pawel Chmielewski
@ 2023-10-11 13:13 ` Pawel Chmielewski
1 sibling, 0 replies; 6+ messages in thread
From: Pawel Chmielewski @ 2023-10-11 13:13 UTC (permalink / raw)
To: netdev
Cc: intel-wired-lan, andrew, aelior, manishc, horms, vladimir.oltean,
pabeni, davem, edumazet, jdamato, d-tatianin, kuba,
Pawel Chmielewski, Jacob Keller, Przemek Kitszel, Paul Greenwalt
Refactor ice_get_link_ksettings to using forced speed to link modes mapping.
Suggested-by : Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
---
drivers/net/ethernet/intel/ice/ice.h | 1 +
drivers/net/ethernet/intel/ice/ice_ethtool.c | 193 ++++++++++++-------
drivers/net/ethernet/intel/ice/ice_main.c | 2 +
3 files changed, 131 insertions(+), 65 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index fcaa5c3b8ec0..988b177d9388 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -960,6 +960,7 @@ int ice_stop(struct net_device *netdev);
void ice_service_task_schedule(struct ice_pf *pf);
int ice_load(struct ice_pf *pf);
void ice_unload(struct ice_pf *pf);
+void ice_adv_lnk_speed_maps_init(void);
/**
* ice_set_rdma_cap - enable RDMA support
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index d3cb08e66dcb..d406eca03cde 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -345,6 +345,79 @@ static const struct ice_priv_flag ice_gstrings_priv_flags[] = {
#define ICE_PRIV_FLAG_ARRAY_SIZE ARRAY_SIZE(ice_gstrings_priv_flags)
+static const u32 ice_adv_lnk_speed_100[] __initconst = {
+ ETHTOOL_LINK_MODE_100baseT_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_1000[] __initconst = {
+ ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
+ ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
+ ETHTOOL_LINK_MODE_1000baseKX_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_2500[] __initconst = {
+ ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
+ ETHTOOL_LINK_MODE_2500baseX_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_5000[] __initconst = {
+ ETHTOOL_LINK_MODE_5000baseT_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_10000[] __initconst = {
+ ETHTOOL_LINK_MODE_10000baseT_Full_BIT,
+ ETHTOOL_LINK_MODE_10000baseKR_Full_BIT,
+ ETHTOOL_LINK_MODE_10000baseSR_Full_BIT,
+ ETHTOOL_LINK_MODE_10000baseLR_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_25000[] __initconst = {
+ ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_40000[] __initconst = {
+ ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT,
+ ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT,
+ ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT,
+ ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_50000[] __initconst = {
+ ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
+ ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
+ ETHTOOL_LINK_MODE_50000baseSR2_Full_BIT,
+};
+
+static const u32 ice_adv_lnk_speed_100000[] __initconst = {
+ ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseCR2_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseSR2_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseKR2_Full_BIT,
+};
+
+static struct ethtool_forced_speed_map ice_adv_lnk_speed_maps[] __ro_after_init = {
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 100),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 1000),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 2500),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 5000),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 10000),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 25000),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 40000),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 50000),
+ ETHTOOL_FORCED_SPEED_MAP(ice_adv_lnk_speed, 100000),
+};
+
+void __init ice_adv_lnk_speed_maps_init(void)
+{
+ ethtool_forced_speed_maps_init(ice_adv_lnk_speed_maps,
+ ARRAY_SIZE(ice_adv_lnk_speed_maps));
+}
+
static void
__ice_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo,
struct ice_vsi *vsi)
@@ -2007,6 +2080,55 @@ ice_get_link_ksettings(struct net_device *netdev,
return err;
}
+/**
+ * ice_speed_to_aq_link - Get AQ link speed by Ethtool forced speed
+ * @speed: ethtool forced speed
+ */
+static u16 ice_speed_to_aq_link(int speed)
+{
+ int aq_speed;
+
+ switch (speed) {
+ case SPEED_10:
+ aq_speed = ICE_AQ_LINK_SPEED_10MB;
+ break;
+ case SPEED_100:
+ aq_speed = ICE_AQ_LINK_SPEED_100MB;
+ break;
+ case SPEED_1000:
+ aq_speed = ICE_AQ_LINK_SPEED_1000MB;
+ break;
+ case SPEED_2500:
+ aq_speed = ICE_AQ_LINK_SPEED_2500MB;
+ break;
+ case SPEED_5000:
+ aq_speed = ICE_AQ_LINK_SPEED_5GB;
+ break;
+ case SPEED_10000:
+ aq_speed = ICE_AQ_LINK_SPEED_10GB;
+ break;
+ case SPEED_20000:
+ aq_speed = ICE_AQ_LINK_SPEED_20GB;
+ break;
+ case SPEED_25000:
+ aq_speed = ICE_AQ_LINK_SPEED_25GB;
+ break;
+ case SPEED_40000:
+ aq_speed = ICE_AQ_LINK_SPEED_40GB;
+ break;
+ case SPEED_50000:
+ aq_speed = ICE_AQ_LINK_SPEED_50GB;
+ break;
+ case SPEED_100000:
+ aq_speed = ICE_AQ_LINK_SPEED_100GB;
+ break;
+ default:
+ aq_speed = ICE_AQ_LINK_SPEED_UNKNOWN;
+ break;
+ }
+ return aq_speed;
+}
+
/**
* ice_ksettings_find_adv_link_speed - Find advertising link speed
* @ks: ethtool ksettings
@@ -2014,73 +2136,14 @@ ice_get_link_ksettings(struct net_device *netdev,
static u16
ice_ksettings_find_adv_link_speed(const struct ethtool_link_ksettings *ks)
{
+ const struct ethtool_forced_speed_map *map;
u16 adv_link_speed = 0;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100baseT_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_100MB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 1000baseX_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 1000baseT_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 1000baseKX_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_1000MB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 2500baseT_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 2500baseX_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_2500MB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 5000baseT_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_5GB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 10000baseT_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 10000baseKR_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 10000baseSR_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 10000baseLR_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_10GB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 25000baseCR_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 25000baseSR_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 25000baseKR_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_25GB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 40000baseCR4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 40000baseSR4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 40000baseLR4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 40000baseKR4_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_40GB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 50000baseCR2_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 50000baseKR2_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 50000baseSR2_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_50GB;
- if (ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseCR4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseSR4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseLR4_ER4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseKR4_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseCR2_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseSR2_Full) ||
- ethtool_link_ksettings_test_link_mode(ks, advertising,
- 100000baseKR2_Full))
- adv_link_speed |= ICE_AQ_LINK_SPEED_100GB;
+ for (u32 i = 0; i < ARRAY_SIZE(ice_adv_lnk_speed_maps); i++) {
+ map = ice_adv_lnk_speed_maps + i;
+ if (linkmode_intersects(ks->link_modes.advertising, map->caps))
+ adv_link_speed |= ice_speed_to_aq_link(map->speed);
+ }
return adv_link_speed;
}
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index c726913bc635..0dd7f23395b0 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5633,6 +5633,8 @@ static int __init ice_module_init(void)
pr_info("%s\n", ice_driver_string);
pr_info("%s\n", ice_copyright);
+ ice_adv_lnk_speed_maps_init();
+
ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
if (!ice_wq) {
pr_err("Failed to create workqueue\n");
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps
2023-10-11 13:13 ` [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps Pawel Chmielewski
@ 2023-10-11 15:12 ` Jiri Pirko
2023-10-12 13:33 ` Pawel Chmielewski
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Pirko @ 2023-10-11 15:12 UTC (permalink / raw)
To: Pawel Chmielewski
Cc: netdev, intel-wired-lan, andrew, aelior, manishc, horms,
vladimir.oltean, pabeni, davem, edumazet, jdamato, d-tatianin,
kuba, Paul Greenwalt, Jacob Keller, Przemek Kitszel
Wed, Oct 11, 2023 at 03:13:47PM CEST, pawel.chmielewski@intel.com wrote:
>From: Paul Greenwalt <paul.greenwalt@intel.com>
>
>The need to map Ethtool forced speeds to Ethtool supported link modes is
>common among drivers. To support this, add a common structure for forced
>speed maps and a function to init them. This is solution was originally
>introduced in commit 1d4e4ecccb11 ("qede: populate supported link modes
>maps on module init") for qede driver.
>
>ethtool_forced_speed_maps_init() should be called during driver init
>with an array of struct ethtool_forced_speed_map to populate the mapping.
>
>Definitions for maps themselves are left in the driver code, as the sets
>of supported link modes may vary between the devices.
>
>The qede driver was compile tested only.
>
>Suggested-by: Andrew Lunn <andrew@lunn.ch>
>Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
>Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
>---
> .../net/ethernet/qlogic/qede/qede_ethtool.c | 46 +++++--------------
> include/linux/ethtool.h | 27 +++++++++++
> net/ethtool/ioctl.c | 13 ++++++
Would be probably better to this this in 2 patches. 1) Introduce ethtool
infra, 2) convert qede to use it
> 3 files changed, 52 insertions(+), 34 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>index 95820cf1cd6c..d4f2cd13d308 100644
>--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>@@ -201,21 +201,6 @@ static const char qede_tests_str_arr[QEDE_ETHTOOL_TEST_MAX][ETH_GSTRING_LEN] = {
>
> /* Forced speed capabilities maps */
>
>-struct qede_forced_speed_map {
>- u32 speed;
>- __ETHTOOL_DECLARE_LINK_MODE_MASK(caps);
>-
>- const u32 *cap_arr;
>- u32 arr_size;
>-};
>-
>-#define QEDE_FORCED_SPEED_MAP(value) \
>-{ \
>- .speed = SPEED_##value, \
>- .cap_arr = qede_forced_speed_##value, \
>- .arr_size = ARRAY_SIZE(qede_forced_speed_##value), \
>-}
>-
> static const u32 qede_forced_speed_1000[] __initconst = {
> ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
> ETHTOOL_LINK_MODE_1000baseKX_Full_BIT,
>@@ -263,28 +248,21 @@ static const u32 qede_forced_speed_100000[] __initconst = {
> ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
> };
>
>-static struct qede_forced_speed_map qede_forced_speed_maps[] __ro_after_init = {
>- QEDE_FORCED_SPEED_MAP(1000),
>- QEDE_FORCED_SPEED_MAP(10000),
>- QEDE_FORCED_SPEED_MAP(20000),
>- QEDE_FORCED_SPEED_MAP(25000),
>- QEDE_FORCED_SPEED_MAP(40000),
>- QEDE_FORCED_SPEED_MAP(50000),
>- QEDE_FORCED_SPEED_MAP(100000),
>+static struct ethtool_forced_speed_map
>+ qede_forced_speed_maps[] __ro_after_init = {
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 1000),
This is confusing indentation. What about:
static struct ethtool_forced_speed_map
qede_forced_speed_maps[] __ro_after_init = {
ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 1000),
?
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 10000),
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 20000),
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 25000),
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 40000),
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 50000),
>+ ETHTOOL_FORCED_SPEED_MAP(qede_forced_speed, 100000),
> };
>
> void __init qede_forced_speed_maps_init(void)
> {
>- struct qede_forced_speed_map *map;
>- u32 i;
>-
>- for (i = 0; i < ARRAY_SIZE(qede_forced_speed_maps); i++) {
>- map = qede_forced_speed_maps + i;
>-
>- linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
>- map->cap_arr = NULL;
>- map->arr_size = 0;
>- }
>+ ethtool_forced_speed_maps_init(qede_forced_speed_maps,
>+ ARRAY_SIZE(qede_forced_speed_maps));
> }
>
> /* Ethtool callbacks */
>@@ -564,8 +542,8 @@ static int qede_set_link_ksettings(struct net_device *dev,
> const struct ethtool_link_ksettings *cmd)
> {
> const struct ethtool_link_settings *base = &cmd->base;
>+ const struct ethtool_forced_speed_map *map;
> struct qede_dev *edev = netdev_priv(dev);
>- const struct qede_forced_speed_map *map;
> struct qed_link_output current_link;
> struct qed_link_params params;
> u32 i;
>diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
>index 62b61527bcc4..68d682012e9d 100644
>--- a/include/linux/ethtool.h
>+++ b/include/linux/ethtool.h
>@@ -1052,4 +1052,31 @@ static inline int ethtool_mm_frag_size_min_to_add(u32 val_min, u32 *val_add,
> * next string.
> */
> extern __printf(2, 3) void ethtool_sprintf(u8 **data, const char *fmt, ...);
>+
>+/* Link mode to forced speed capabilities maps */
>+struct ethtool_forced_speed_map {
>+ u32 speed;
>+ __ETHTOOL_DECLARE_LINK_MODE_MASK(caps);
>+
>+ const u32 *cap_arr;
>+ u32 arr_size;
>+};
>+
>+#define ETHTOOL_FORCED_SPEED_MAP(prefix, value) \
>+{ \
>+ .speed = SPEED_##value, \
>+ .cap_arr = prefix##_##value, \
>+ .arr_size = ARRAY_SIZE(prefix##_##value), \
>+}
>+
>+/**
>+ * ethtool_forced_speed_maps_init
>+ * @maps: Pointer to an array of Ethtool forced speed map
>+ * @size: Array size
>+ *
>+ * Initialize an array of Ethtool forced speed map to Ethtool link modes. This
>+ * should be called during driver module init.
>+ */
>+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
>+ u32 size);
> #endif /* _LINUX_ETHTOOL_H */
>diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
Why you put this into ioctl.c?
Can't this be put into include/linux/linkmode.h as a static helper as
well?
>index 0b0ce4f81c01..34507691fc9d 100644
>--- a/net/ethtool/ioctl.c
>+++ b/net/ethtool/ioctl.c
>@@ -3388,3 +3388,16 @@ void ethtool_rx_flow_rule_destroy(struct ethtool_rx_flow_rule *flow)
> kfree(flow);
> }
> EXPORT_SYMBOL(ethtool_rx_flow_rule_destroy);
>+
>+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
>+ u32 size)
>+{
>+ for (u32 i = 0; i < size; i++) {
>+ struct ethtool_forced_speed_map *map = &maps[i];
>+
>+ linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
>+ map->cap_arr = NULL;
>+ map->arr_size = 0;
>+ }
>+}
>+EXPORT_SYMBOL(ethtool_forced_speed_maps_init);
>--
>2.37.3
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps
2023-10-11 15:12 ` Jiri Pirko
@ 2023-10-12 13:33 ` Pawel Chmielewski
2023-10-12 13:42 ` Jiri Pirko
0 siblings, 1 reply; 6+ messages in thread
From: Pawel Chmielewski @ 2023-10-12 13:33 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev, intel-wired-lan, andrew, aelior, manishc, horms,
vladimir.oltean, pabeni, davem, edumazet, jdamato, d-tatianin,
kuba, Paul Greenwalt, Jacob Keller, Przemek Kitszel
> >diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
>
> Why you put this into ioctl.c?
>
> Can't this be put into include/linux/linkmode.h as a static helper as
> well?
I'm a little bit confused, include/linux/linkmode.h doesn't contain
similar ethtool helpers.. Did you maybe meant ethtool.h?
>
> >index 0b0ce4f81c01..34507691fc9d 100644
> >--- a/net/ethtool/ioctl.c
> >+++ b/net/ethtool/ioctl.c
> >@@ -3388,3 +3388,16 @@ void ethtool_rx_flow_rule_destroy(struct ethtool_rx_flow_rule *flow)
> > kfree(flow);
> > }
> > EXPORT_SYMBOL(ethtool_rx_flow_rule_destroy);
> >+
> >+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
> >+ u32 size)
> >+{
> >+ for (u32 i = 0; i < size; i++) {
> >+ struct ethtool_forced_speed_map *map = &maps[i];
> >+
> >+ linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
> >+ map->cap_arr = NULL;
> >+ map->arr_size = 0;
> >+ }
> >+}
> >+EXPORT_SYMBOL(ethtool_forced_speed_maps_init);
> >--
> >2.37.3
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps
2023-10-12 13:33 ` Pawel Chmielewski
@ 2023-10-12 13:42 ` Jiri Pirko
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2023-10-12 13:42 UTC (permalink / raw)
To: Pawel Chmielewski
Cc: netdev, intel-wired-lan, andrew, aelior, manishc, horms,
vladimir.oltean, pabeni, davem, edumazet, jdamato, d-tatianin,
kuba, Paul Greenwalt, Jacob Keller, Przemek Kitszel
Thu, Oct 12, 2023 at 03:33:15PM CEST, pawel.chmielewski@intel.com wrote:
>> >diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
>>
>> Why you put this into ioctl.c?
>>
>> Can't this be put into include/linux/linkmode.h as a static helper as
>> well?
>
>I'm a little bit confused, include/linux/linkmode.h doesn't contain
>similar ethtool helpers.. Did you maybe meant ethtool.h?
I just looked there linkmode_set_bit_array is. ethtool.h might be the
place.
>
>>
>> >index 0b0ce4f81c01..34507691fc9d 100644
>> >--- a/net/ethtool/ioctl.c
>> >+++ b/net/ethtool/ioctl.c
>> >@@ -3388,3 +3388,16 @@ void ethtool_rx_flow_rule_destroy(struct ethtool_rx_flow_rule *flow)
>> > kfree(flow);
>> > }
>> > EXPORT_SYMBOL(ethtool_rx_flow_rule_destroy);
>> >+
>> >+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
>> >+ u32 size)
>> >+{
>> >+ for (u32 i = 0; i < size; i++) {
>> >+ struct ethtool_forced_speed_map *map = &maps[i];
>> >+
>> >+ linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
>> >+ map->cap_arr = NULL;
>> >+ map->arr_size = 0;
>> >+ }
>> >+}
>> >+EXPORT_SYMBOL(ethtool_forced_speed_maps_init);
>> >--
>> >2.37.3
>> >
>> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-12 13:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-11 13:13 [PATCH net-next v4 0/2] ethtool: Add link mode maps for forced speeds Pawel Chmielewski
2023-10-11 13:13 ` [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps Pawel Chmielewski
2023-10-11 15:12 ` Jiri Pirko
2023-10-12 13:33 ` Pawel Chmielewski
2023-10-12 13:42 ` Jiri Pirko
2023-10-11 13:13 ` [PATCH net-next v4 2/2] ice: Refactor finding advertised link speed Pawel Chmielewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox