From: Hangbin Liu <liuhangbin@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
Daniel Mendes <dmendes@redhat.com>
Subject: Re: [PATCH net] kselftest: rtnetlink: fix ip route command typo
Date: Fri, 17 Nov 2023 09:15:59 +0800 [thread overview]
Message-ID: <ZVa+z0yqUzb5Wgt7@Laptop-X1> (raw)
In-Reply-To: <aabeb7c156a45c878e1ea94a6d715e6908f330a4.1700136983.git.pabeni@redhat.com>
On Thu, Nov 16, 2023 at 06:01:41PM +0100, Paolo Abeni wrote:
> The blamed commit below introduced a typo causing 'gretap' test-case
> failures:
>
> ./rtnetlink.sh -t kci_test_gretap -v
> COMMAND: ip link add name test-dummy0 type dummy
> COMMAND: ip link set test-dummy0 up
> COMMAND: ip netns add testns
> COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:'
> COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200
> COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24
> COMMAND: ip -netns testns link set dev gretap00 ups
> Error: either "dev" is duplicate, or "ups" is a garbage.
> COMMAND: ip -netns testns link del gretap00
> COMMAND: ip -netns testns link add dev gretap00 type gretap external
> COMMAND: ip -netns testns link del gretap00
> FAIL: gretap
>
> Fix it by using the correct keyword.
>
> Fixes: 9c2a19f71515 ("kselftest: rtnetlink.sh: add verbose flag")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> tools/testing/selftests/net/rtnetlink.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 5f2b3f6c0d74..38be9706c45f 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -859,7 +859,7 @@ kci_test_gretap()
>
>
> run_cmd ip -netns "$testns" addr add dev "$DEV_NS" 10.1.1.100/24
> - run_cmd ip -netns "$testns" link set dev $DEV_NS ups
> + run_cmd ip -netns "$testns" link set dev $DEV_NS up
> run_cmd ip -netns "$testns" link del "$DEV_NS"
>
> # test external mode
> --
> 2.41.0
>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2023-11-17 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 17:01 [PATCH net] kselftest: rtnetlink: fix ip route command typo Paolo Abeni
2023-11-17 1:15 ` Hangbin Liu [this message]
2023-11-17 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVa+z0yqUzb5Wgt7@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dmendes@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox