[PATCH net] kselftest: rtnetlink: fix ip route command typo

[PATCH net] kselftest: rtnetlink: fix ip route command typo

[Paolo Abeni]

The blamed commit below introduced a typo causing 'gretap' test-case
failures:

./rtnetlink.sh  -t kci_test_gretap -v
COMMAND: ip link add name test-dummy0 type dummy
COMMAND: ip link set test-dummy0 up
COMMAND: ip netns add testns
COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:'
COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200
COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24
COMMAND: ip -netns testns link set dev gretap00 ups
    Error: either "dev" is duplicate, or "ups" is a garbage.
COMMAND: ip -netns testns link del gretap00
COMMAND: ip -netns testns link add dev gretap00 type gretap external
COMMAND: ip -netns testns link del gretap00
FAIL: gretap

Fix it by using the correct keyword.

Fixes: 9c2a19f71515 ("kselftest: rtnetlink.sh: add verbose flag")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 tools/testing/selftests/net/rtnetlink.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 5f2b3f6c0d74..38be9706c45f 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -859,7 +859,7 @@ kci_test_gretap()
 
 
 	run_cmd ip -netns "$testns" addr add dev "$DEV_NS" 10.1.1.100/24
-	run_cmd ip -netns "$testns" link set dev $DEV_NS ups
+	run_cmd ip -netns "$testns" link set dev $DEV_NS up
 	run_cmd ip -netns "$testns" link del "$DEV_NS"
 
 	# test external mode
-- 
2.41.0

Re: [PATCH net] kselftest: rtnetlink: fix ip route command typo

[Hangbin Liu]

On Thu, Nov 16, 2023 at 06:01:41PM +0100, Paolo Abeni wrote:
> The blamed commit below introduced a typo causing 'gretap' test-case
> failures:
> 
> ./rtnetlink.sh  -t kci_test_gretap -v
> COMMAND: ip link add name test-dummy0 type dummy
> COMMAND: ip link set test-dummy0 up
> COMMAND: ip netns add testns
> COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:'
> COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200
> COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24
> COMMAND: ip -netns testns link set dev gretap00 ups
>     Error: either "dev" is duplicate, or "ups" is a garbage.
> COMMAND: ip -netns testns link del gretap00
> COMMAND: ip -netns testns link add dev gretap00 type gretap external
> COMMAND: ip -netns testns link del gretap00
> FAIL: gretap
> 
> Fix it by using the correct keyword.
> 
> Fixes: 9c2a19f71515 ("kselftest: rtnetlink.sh: add verbose flag")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 5f2b3f6c0d74..38be9706c45f 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -859,7 +859,7 @@ kci_test_gretap()
>  
>  
>  	run_cmd ip -netns "$testns" addr add dev "$DEV_NS" 10.1.1.100/24
> -	run_cmd ip -netns "$testns" link set dev $DEV_NS ups
> +	run_cmd ip -netns "$testns" link set dev $DEV_NS up
>  	run_cmd ip -netns "$testns" link del "$DEV_NS"
>  
>  	# test external mode
> -- 
> 2.41.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

Re: [PATCH net] kselftest: rtnetlink: fix ip route command typo

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 16 Nov 2023 18:01:41 +0100 you wrote:
> The blamed commit below introduced a typo causing 'gretap' test-case
> failures:
> 
> ./rtnetlink.sh  -t kci_test_gretap -v
> COMMAND: ip link add name test-dummy0 type dummy
> COMMAND: ip link set test-dummy0 up
> COMMAND: ip netns add testns
> COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:'
> COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200
> COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24
> COMMAND: ip -netns testns link set dev gretap00 ups
>     Error: either "dev" is duplicate, or "ups" is a garbage.
> COMMAND: ip -netns testns link del gretap00
> COMMAND: ip -netns testns link add dev gretap00 type gretap external
> COMMAND: ip -netns testns link del gretap00
> FAIL: gretap
> 
> [...]

Here is the summary with links:
  - [net] kselftest: rtnetlink: fix ip route command typo
    https://git.kernel.org/netdev/net/c/75a50c4f5b95

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html