From: Benjamin Poirier <bpoirier@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, j.vosburgh@gmail.com, andy@greyhouse.net,
shuah@kernel.org, jon.toppins+linux@gmail.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: bonding: add missing build configs
Date: Tue, 16 Jan 2024 09:37:40 -0500 [thread overview]
Message-ID: <ZaaUtIuKBQByp4j4@d3> (raw)
In-Reply-To: <20240116020201.1883023-1-kuba@kernel.org>
On 2024-01-15 18:02 -0800, Jakub Kicinski wrote:
> bonding tests also try to create bridge, veth and dummy
> interfaces. These are not currently listed in config.
>
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management")
> Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: j.vosburgh@gmail.com
> CC: andy@greyhouse.net
> CC: shuah@kernel.org
> CC: bpoirier@nvidia.com
> CC: jon.toppins+linux@gmail.com
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/drivers/net/bonding/config | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config
> index 70638fa50b2c..f85b16fc5128 100644
> --- a/tools/testing/selftests/drivers/net/bonding/config
> +++ b/tools/testing/selftests/drivers/net/bonding/config
> @@ -1,2 +1,5 @@
> CONFIG_BONDING=y
> +CONFIG_BRIDGE=y
> +CONFIG_DUMMY=y
> CONFIG_MACVLAN=y
> +CONFIG_VETH=y
> --
Hi,
I tested using the minimal config generated by virtme-ng and the
following additional config options need to be enabled for bonding
tests:
CONFIG_IPV6=y
CONFIG_NET_ACT_GACT=y
CONFIG_NET_CLS_FLOWER=y
CONFIG_NET_SCH_INGRESS=y
CONFIG_NLMON=y
next prev parent reply other threads:[~2024-01-16 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 2:02 [PATCH net] selftests: bonding: add missing build configs Jakub Kicinski
2024-01-16 6:20 ` Muhammad Usama Anjum
2024-01-16 14:37 ` Benjamin Poirier [this message]
2024-01-16 15:00 ` Jakub Kicinski
2024-01-16 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaaUtIuKBQByp4j4@d3 \
--to=bpoirier@nvidia.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jon.toppins+linux@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox