* [PATCH net] selftests: bonding: add missing build configs
@ 2024-01-16 2:02 Jakub Kicinski
2024-01-16 6:20 ` Muhammad Usama Anjum
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jakub Kicinski @ 2024-01-16 2:02 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, Jakub Kicinski, j.vosburgh, andy, shuah,
bpoirier, jon.toppins+linux, linux-kselftest
bonding tests also try to create bridge, veth and dummy
interfaces. These are not currently listed in config.
Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management")
Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: j.vosburgh@gmail.com
CC: andy@greyhouse.net
CC: shuah@kernel.org
CC: bpoirier@nvidia.com
CC: jon.toppins+linux@gmail.com
CC: linux-kselftest@vger.kernel.org
---
tools/testing/selftests/drivers/net/bonding/config | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config
index 70638fa50b2c..f85b16fc5128 100644
--- a/tools/testing/selftests/drivers/net/bonding/config
+++ b/tools/testing/selftests/drivers/net/bonding/config
@@ -1,2 +1,5 @@
CONFIG_BONDING=y
+CONFIG_BRIDGE=y
+CONFIG_DUMMY=y
CONFIG_MACVLAN=y
+CONFIG_VETH=y
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: bonding: add missing build configs
2024-01-16 2:02 [PATCH net] selftests: bonding: add missing build configs Jakub Kicinski
@ 2024-01-16 6:20 ` Muhammad Usama Anjum
2024-01-16 14:37 ` Benjamin Poirier
2024-01-16 15:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2024-01-16 6:20 UTC (permalink / raw)
To: Jakub Kicinski, davem
Cc: Muhammad Usama Anjum, netdev, edumazet, pabeni, j.vosburgh, andy,
shuah, bpoirier, jon.toppins+linux, linux-kselftest
On 1/16/24 7:02 AM, Jakub Kicinski wrote:
> bonding tests also try to create bridge, veth and dummy
> interfaces. These are not currently listed in config.
>
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management")
> Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> CC: j.vosburgh@gmail.com
> CC: andy@greyhouse.net
> CC: shuah@kernel.org
> CC: bpoirier@nvidia.com
> CC: jon.toppins+linux@gmail.com
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/drivers/net/bonding/config | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config
> index 70638fa50b2c..f85b16fc5128 100644
> --- a/tools/testing/selftests/drivers/net/bonding/config
> +++ b/tools/testing/selftests/drivers/net/bonding/config
> @@ -1,2 +1,5 @@
> CONFIG_BONDING=y
> +CONFIG_BRIDGE=y
> +CONFIG_DUMMY=y
> CONFIG_MACVLAN=y
> +CONFIG_VETH=y
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: bonding: add missing build configs
2024-01-16 2:02 [PATCH net] selftests: bonding: add missing build configs Jakub Kicinski
2024-01-16 6:20 ` Muhammad Usama Anjum
@ 2024-01-16 14:37 ` Benjamin Poirier
2024-01-16 15:00 ` Jakub Kicinski
2024-01-16 15:10 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Benjamin Poirier @ 2024-01-16 14:37 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, j.vosburgh, andy, shuah,
jon.toppins+linux, linux-kselftest
On 2024-01-15 18:02 -0800, Jakub Kicinski wrote:
> bonding tests also try to create bridge, veth and dummy
> interfaces. These are not currently listed in config.
>
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management")
> Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: j.vosburgh@gmail.com
> CC: andy@greyhouse.net
> CC: shuah@kernel.org
> CC: bpoirier@nvidia.com
> CC: jon.toppins+linux@gmail.com
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/drivers/net/bonding/config | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config
> index 70638fa50b2c..f85b16fc5128 100644
> --- a/tools/testing/selftests/drivers/net/bonding/config
> +++ b/tools/testing/selftests/drivers/net/bonding/config
> @@ -1,2 +1,5 @@
> CONFIG_BONDING=y
> +CONFIG_BRIDGE=y
> +CONFIG_DUMMY=y
> CONFIG_MACVLAN=y
> +CONFIG_VETH=y
> --
Hi,
I tested using the minimal config generated by virtme-ng and the
following additional config options need to be enabled for bonding
tests:
CONFIG_IPV6=y
CONFIG_NET_ACT_GACT=y
CONFIG_NET_CLS_FLOWER=y
CONFIG_NET_SCH_INGRESS=y
CONFIG_NLMON=y
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: bonding: add missing build configs
2024-01-16 14:37 ` Benjamin Poirier
@ 2024-01-16 15:00 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2024-01-16 15:00 UTC (permalink / raw)
To: Benjamin Poirier
Cc: davem, netdev, edumazet, pabeni, j.vosburgh, andy, shuah,
jon.toppins+linux, linux-kselftest
On Tue, 16 Jan 2024 09:37:40 -0500 Benjamin Poirier wrote:
> I tested using the minimal config generated by virtme-ng and the
> following additional config options need to be enabled for bonding
> tests:
> CONFIG_IPV6=y
> CONFIG_NET_ACT_GACT=y
> CONFIG_NET_CLS_FLOWER=y
> CONFIG_NET_SCH_INGRESS=y
> CONFIG_NLMON=y
Perfect! Could you post a patch to add those?
I'll apply this one right away to avoid conflicts.
Fixes tags would be good to have, if you don't feel like
finding each individual commit you can point at mine :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] selftests: bonding: add missing build configs
2024-01-16 2:02 [PATCH net] selftests: bonding: add missing build configs Jakub Kicinski
2024-01-16 6:20 ` Muhammad Usama Anjum
2024-01-16 14:37 ` Benjamin Poirier
@ 2024-01-16 15:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-16 15:10 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, j.vosburgh, andy, shuah,
bpoirier, jon.toppins+linux, linux-kselftest
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 15 Jan 2024 18:02:01 -0800 you wrote:
> bonding tests also try to create bridge, veth and dummy
> interfaces. These are not currently listed in config.
>
> Fixes: bbb774d921e2 ("net: Add tests for bonding and team address list management")
> Fixes: c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net] selftests: bonding: add missing build configs
https://git.kernel.org/netdev/net/c/03fb8565c880
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-16 15:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-16 2:02 [PATCH net] selftests: bonding: add missing build configs Jakub Kicinski
2024-01-16 6:20 ` Muhammad Usama Anjum
2024-01-16 14:37 ` Benjamin Poirier
2024-01-16 15:00 ` Jakub Kicinski
2024-01-16 15:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox