Re: [PATCH net-next] net: team: fix incorrect maxattr

[Hangbin Liu <liuhangbin@gmail.com>]

On Tue, Apr 09, 2024 at 05:28:12PM +0800, Hangbin Liu wrote:
> The maxattr should be the latest attr value, i.e. array size - 1,
> not total array size.
> 
> Reported-by: syzbot+ecd7e07b4be038658c9f@syzkaller.appspotmail.com
> Fixes: 948dbafc15da ("net: team: use policy generated by YAML spec")
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  drivers/net/team/team_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
> index 4e3c8d404957..8c7dbaf7c22e 100644
> --- a/drivers/net/team/team_core.c
> +++ b/drivers/net/team/team_core.c
> @@ -2808,7 +2808,7 @@ static const struct genl_multicast_group team_nl_mcgrps[] = {
>  static struct genl_family team_nl_family __ro_after_init = {
>  	.name		= TEAM_GENL_NAME,
>  	.version	= TEAM_GENL_VERSION,
> -	.maxattr	= ARRAY_SIZE(team_nl_policy),
> +	.maxattr	= ARRAY_SIZE(team_nl_policy) - 1,
>  	.policy = team_nl_policy,
>  	.netnsok	= true,
>  	.module		= THIS_MODULE,
> -- 
> 2.43.0
> 

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git main