public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: team: fix incorrect maxattr
@ 2024-04-09  9:28 Hangbin Liu
  2024-04-09  9:41 ` Hangbin Liu
  2024-04-11  2:40 ` [PATCH net-next] net: team: fix incorrect maxattr patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Hangbin Liu @ 2024-04-09  9:28 UTC (permalink / raw)
  To: netdev
  Cc: Jiri Pirko, Jakub Kicinski, Paolo Abeni, Eric Dumazet,
	Hangbin Liu, syzbot+ecd7e07b4be038658c9f

The maxattr should be the latest attr value, i.e. array size - 1,
not total array size.

Reported-by: syzbot+ecd7e07b4be038658c9f@syzkaller.appspotmail.com
Fixes: 948dbafc15da ("net: team: use policy generated by YAML spec")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 drivers/net/team/team_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index 4e3c8d404957..8c7dbaf7c22e 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -2808,7 +2808,7 @@ static const struct genl_multicast_group team_nl_mcgrps[] = {
 static struct genl_family team_nl_family __ro_after_init = {
 	.name		= TEAM_GENL_NAME,
 	.version	= TEAM_GENL_VERSION,
-	.maxattr	= ARRAY_SIZE(team_nl_policy),
+	.maxattr	= ARRAY_SIZE(team_nl_policy) - 1,
 	.policy = team_nl_policy,
 	.netnsok	= true,
 	.module		= THIS_MODULE,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-11  2:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-09  9:28 [PATCH net-next] net: team: fix incorrect maxattr Hangbin Liu
2024-04-09  9:41 ` Hangbin Liu
2024-04-10  5:07   ` [syzbot] [net?] KASAN: global-out-of-bounds Read in __nla_validate_parse syzbot
2024-04-11  2:40 ` [PATCH net-next] net: team: fix incorrect maxattr patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox