public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: qstat: extend kdoc about get_base_stats
@ 2024-05-29 16:29 Jakub Kicinski
  2024-05-29 17:59 ` Joe Damato
  2024-06-01 22:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-05-29 16:29 UTC (permalink / raw)
  To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski, jdamato

mlx5 has a dedicated queue for PTP packets. Clarify that
this sort of queues can also be accounted towards the base.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Cc: jdamato@fastly.com
---
 include/net/netdev_queues.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
index a8a7e48dfa6c..5ca019d294ca 100644
--- a/include/net/netdev_queues.h
+++ b/include/net/netdev_queues.h
@@ -62,6 +62,8 @@ struct netdev_queue_stats_tx {
  * statistics will not generally add up to the total number of events for
  * the device. The @get_base_stats callback allows filling in the delta
  * between events for currently live queues and overall device history.
+ * @get_base_stats can also be used to report any miscellaneous packets
+ * transferred outside of the main set of queues used by the networking stack.
  * When the statistics for the entire device are queried, first @get_base_stats
  * is issued to collect the delta, and then a series of per-queue callbacks.
  * Only statistics which are set in @get_base_stats will be reported
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: qstat: extend kdoc about get_base_stats
  2024-05-29 16:29 [PATCH net-next] net: qstat: extend kdoc about get_base_stats Jakub Kicinski
@ 2024-05-29 17:59 ` Joe Damato
  2024-06-01 22:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Joe Damato @ 2024-05-29 17:59 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni

On Wed, May 29, 2024 at 09:29:22AM -0700, Jakub Kicinski wrote:
> mlx5 has a dedicated queue for PTP packets. Clarify that
> this sort of queues can also be accounted towards the base.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Cc: jdamato@fastly.com
> ---
>  include/net/netdev_queues.h | 2 ++
>  1 file changed, 2 insertions(+)

Thanks!

Reviewed-by: Joe Damato <jdamato@fastly.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: qstat: extend kdoc about get_base_stats
  2024-05-29 16:29 [PATCH net-next] net: qstat: extend kdoc about get_base_stats Jakub Kicinski
  2024-05-29 17:59 ` Joe Damato
@ 2024-06-01 22:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-01 22:20 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, jdamato

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 29 May 2024 09:29:22 -0700 you wrote:
> mlx5 has a dedicated queue for PTP packets. Clarify that
> this sort of queues can also be accounted towards the base.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Cc: jdamato@fastly.com
> 
> [...]

Here is the summary with links:
  - [net-next] net: qstat: extend kdoc about get_base_stats
    https://git.kernel.org/netdev/net-next/c/69c8b998717c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-01 22:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-29 16:29 [PATCH net-next] net: qstat: extend kdoc about get_base_stats Jakub Kicinski
2024-05-29 17:59 ` Joe Damato
2024-06-01 22:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox